Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dealProvider as base logic #11

Merged
merged 3 commits into from
Mar 21, 2024
Merged

use dealProvider as base logic #11

merged 3 commits into from
Mar 21, 2024

Conversation

YouStillAlive
Copy link
Member

No description provided.

@YouStillAlive YouStillAlive linked an issue Mar 21, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cb18a10) to head (f825e14).

Additional details and impacted files
@@             Coverage Diff              @@
##           master       #11       +/-   ##
============================================
+ Coverage   90.00%   100.00%   +10.00%     
============================================
  Files           3         2        -1     
  Lines          70        44       -26     
  Branches       17         9        -8     
============================================
- Hits           63        44       -19     
+ Misses          7         0        -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YouStillAlive YouStillAlive marked this pull request as ready for review March 21, 2024 10:30
@YouStillAlive YouStillAlive marked this pull request as draft March 21, 2024 10:48
@YouStillAlive YouStillAlive marked this pull request as ready for review March 21, 2024 13:56
@Lomet Lomet merged commit ad14e28 into master Mar 21, 2024
5 checks passed
@YouStillAlive YouStillAlive deleted the issue-6 branch March 21, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use the DealProvider functionality as a base
2 participants