Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dispenser refactor #16

Merged
merged 7 commits into from
Mar 25, 2024
Merged

dispenser refactor #16

merged 7 commits into from
Mar 25, 2024

Conversation

YouStillAlive
Copy link
Member

No description provided.

@YouStillAlive YouStillAlive linked an issue Mar 22, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (79f0638) to head (12bca54).

❗ Current head 12bca54 differs from pull request most recent head 3fc68c2. Consider uploading reports for the commit 3fc68c2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         3    +1     
  Lines           46        44    -2     
  Branches        11        10    -1     
=========================================
- Hits            46        44    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Lomet Lomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

contracts/DispenserInternal.sol Outdated Show resolved Hide resolved
contracts/DispenserInternal.sol Outdated Show resolved Hide resolved
contracts/DispenserInternal.sol Outdated Show resolved Hide resolved
@YouStillAlive YouStillAlive marked this pull request as ready for review March 22, 2024 15:41
Copy link
Member

@Lomet Lomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

contracts/DispenserInternal.sol Outdated Show resolved Hide resolved
contracts/DispenserInternal.sol Show resolved Hide resolved
@YouStillAlive YouStillAlive merged commit da09f9a into master Mar 25, 2024
4 checks passed
@YouStillAlive YouStillAlive deleted the issue-12 branch March 25, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

split internal and external logic into separate files
2 participants