Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify authorization #50

Merged
merged 7 commits into from
Dec 16, 2024
Merged

clarify authorization #50

merged 7 commits into from
Dec 16, 2024

Conversation

YouStillAlive
Copy link
Member

closes #49

Copy link

github-actions bot commented Dec 13, 2024

Methods

Symbol Meaning
Execution gas for this method does not include intrinsic gas overhead
Cost was non-zero but below the precision setting for the currency display (see options)
Min Max Avg Calls usd avg
DispenserProvider
       createNewPool(address[],uint256[],bytes) 294,640 322,940 321,368 18 0.23
       dispenseLock(uint256,uint256,address,(address,uint256[])[],bytes) 309,982 358,180 348,783 11 0.25
ERC20Token
       approve(address,uint256) - - 45,962 18 0.03
LockDealNFT
       setApprovalForAll(address,bool) 24,828 46,740 35,784 4 0.03
       setApprovedContract(address,bool) 48,143 48,155 48,152 4 0.03

Deployments

Min Max Avg Block % usd avg
DealProvider - - 1,558,658 1.2 % 1.11
DispenserProvider - - 2,550,524 2 % 1.82
ERC20Token - - 648,905 0.5 % 0.46
LockDealNFT - - 4,305,889 3.3 % 3.06
LockDealProvider - - 1,707,187 1.3 % 1.22
MockVaultManager - - 322,429 0.2 % 0.23
TimedDealProvider - - 1,854,511 1.4 % 1.32

Solidity and Network Config

Settings Value
Solidity: version 0.8.28
Solidity: optimized true
Solidity: runs 200
Solidity: viaIR true
Block Limit 130,000,000
L1 Gas Price 1 gwei
Token Price 711.78 usd/bnb
Network BINANCE
Toolchain hardhat

Copy link

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

@YouStillAlive YouStillAlive marked this pull request as ready for review December 16, 2024 08:44
Copy link
Member

@Lomet Lomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Comment on lines +80 to +82
function _isReceiver(address receiver) private view returns (bool) {
return receiver == msg.sender;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be pure?

@YouStillAlive YouStillAlive merged commit 49beddf into master Dec 16, 2024
5 checks passed
@YouStillAlive YouStillAlive deleted the issue-17 branch December 16, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add more checks for authorization
2 participants