Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clone cloneVaultId RefundProvider NFT in SimpleRefundBuilder #373

Closed
YouStillAlive opened this issue Dec 26, 2023 · 1 comment · Fixed by #374
Closed

add clone cloneVaultId RefundProvider NFT in SimpleRefundBuilder #373

YouStillAlive opened this issue Dec 26, 2023 · 1 comment · Fixed by #374
Labels
bug Something isn't working

Comments

@YouStillAlive
Copy link
Member

RefundProvider NFT didn't clone the token in the SimpleRefundProvider.

lockDealNFT.mintForProvider(owner, refundProvider);

@YouStillAlive YouStillAlive changed the title add clone cloneVaultId to SimpleRefundBuilder add clone cloneVaultId RefundProvider NFT in SimpleRefundBuilder Dec 26, 2023
@YouStillAlive
Copy link
Member Author

We use the RefundProvider poolId as the token poolId before cloning the token, as result Collateral token poolId to always have a vaultId of zero

@YouStillAlive YouStillAlive linked a pull request Dec 26, 2023 that will close this issue
@YouStillAlive YouStillAlive added the bug Something isn't working label Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant