Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix token vault bug #374

Merged
merged 1 commit into from
Dec 27, 2023
Merged

fix token vault bug #374

merged 1 commit into from
Dec 27, 2023

Conversation

YouStillAlive
Copy link
Member

No description provided.

Copy link

Gas Test Report 📊

The gas test results are as follows:

LockDealNFT

Contract Method Min Max Avg # calls
LockDealNFT approvePoolTransfers(bool) 22087 43999 33043 8
LockDealNFT renounceOwnership() - - 23250 1
LockDealNFT safeTransferFrom(address,address,uint256,bytes) 297968 1277370 638353 28
LockDealNFT safeTransferFrom(address,address,uint256) 112512 342782 184341 25
LockDealNFT setApprovedContract(address,bool) 28217 50617 47744 52
LockDealNFT setBaseURI(string) 51171 79710 70197 3
LockDealNFT transferFrom(address,address,uint256) 98989 117530 108260 2
LockDealNFT transferOwnership(address) - - 28694 1
LockDealNFT updateAllMetadata() - - 24522 2

Simple Providers

Contract Method Min Max Avg # calls
DealProvider createNewPool(address[],uint256[],bytes) 254416 285216 266065 68
LockDealProvider createNewPool(address[],uint256[],bytes) 286980 302431 297717 15
TimedDealProvider createNewPool(address[],uint256[],bytes) 344795 373530 356821 32

Advanced Providers

Contract Method Min Max Avg # calls
BundleProvider createNewPool(address[],uint256[][],bytes) 900747 914747 914323 33
RefundProvider createNewRefundPool(address[],uint256[],bytes,bytes) 1256322 1356372 1346028 30

Builders

Contract Method Min Max Avg # calls
SimpleBuilder buildMassPools(address[],((address,uint256)[],uint256),uint256[],bytes) 2033011 27187859 12326036 18
SimpleRefundBuilder buildMassPools(address[],((address,uint256)[],uint256),uint256[][],bytes,bytes) 4806434 47580916 23579778 18

Deployments

Contract Min Max Avg % of limit
BundleProvider - - 1680984 1.3 %
CollateralProvider 1805085 1805097 1805094 1.4 %
DealProvider - - 828116 0.6 %
ERC20Token - - 790840 0.6 %
LockDealNFT 3746098 3811333 3748885 2.9 %
LockDealProvider 1028219 1028231 1028228 0.8 %
RefundProvider - - 1984415 1.5 %
SimpleBuilder - - 795301 0.6 %
TimedDealProvider - - 1145812 0.9 %

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29fc717) 99.84% compared to head (acf4fc7) 99.85%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #374   +/-   ##
=======================================
  Coverage   99.84%   99.85%           
=======================================
  Files          22       22           
  Lines         662      695   +33     
  Branches      140      144    +4     
=======================================
+ Hits          661      694   +33     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YouStillAlive YouStillAlive linked an issue Dec 26, 2023 that may be closed by this pull request
@Lomet Lomet merged commit 9d2bd80 into master Dec 27, 2023
5 checks passed
@Lomet Lomet deleted the simple-refund-builder branch December 27, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add clone cloneVaultId RefundProvider NFT in SimpleRefundBuilder
2 participants