Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleBuilder #312

Merged
merged 13 commits into from
Sep 20, 2023
Merged

SimpleBuilder #312

merged 13 commits into from
Sep 20, 2023

Conversation

YouStillAlive
Copy link
Member

closes #310

@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Gas Test Report 📊

The gas test results are as follows:

Methods

Contract Method Min Max Avg # calls
BundleProvider createNewPool(address[],uint256[][]) 898565 912565 912113 31
CollateralProvider createNewPool(address[],uint256[]) - - 786474 1
DealProvider createNewPool(address[],uint256[]) 252202 283002 263910 61
LockDealNFT approvePoolTransfers(bool) 22087 43999 33043 6
LockDealNFT safeTransferFrom(address,address,uint256,bytes) 285273 1196408 611852 28
LockDealNFT safeTransferFrom(address,address,uint256) 105236 337003 173604 25
LockDealNFT setApprovedProvider(address,bool) 28128 50528 47574 43
LockDealNFT setBaseURI(string) 51139 79678 70165 3
LockDealNFT transferFrom(address,address,uint256) - - 103440 1
LockDealNFT updateAllMetadata() - - 24500 2
LockDealProvider createNewPool(address[],uint256[]) 284801 300291 295540 15
RefundProvider createNewRefundPool(address[],uint256[]) 1236284 1328705 1320940 27
SimpleBuilder buildMassPools(address[],(address,uint256)[],uint256[]) 2199072 27711187 12620444 27
TimedDealProvider createNewPool(address[],uint256[]) 342528 371266 354568 31

Deployments

Contract Min Max Avg % of limit
BundleProvider - - 1539915 5.1 %
CollateralProvider 1702891 1702903 1702895 5.7 %
DealProvider 782985 782997 782996 2.6 %
LockDealNFT 3430739 3495974 3432401 11.4 %
LockDealProvider 983012 983036 983029 3.3 %
RefundProvider 2013791 2013803 2013792 6.7 %
SimpleBuilder - - 655021 2.2 %
TimedDealProvider 1102464 1102476 1102474 3.7 %

Copy link
Member

@Lomet Lomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start

contracts/Builders/SimpleBuilder.sol Outdated Show resolved Hide resolved
contracts/Builders/SimpleBuilder.sol Show resolved Hide resolved
contracts/Builders/SimpleBuilder.sol Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #312 (2613611) into master (2455b3a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 2613611 differs from pull request most recent head 11ddc7b. Consider uploading reports for the commit 11ddc7b to get more accurate results

@@           Coverage Diff           @@
##           master     #312   +/-   ##
=======================================
  Coverage   99.81%   99.82%           
=======================================
  Files          19       20    +1     
  Lines         540      570   +30     
  Branches      120      126    +6     
=======================================
+ Hits          539      569   +30     
  Misses          1        1           
Files Changed Coverage Δ
contracts/Builders/SimpleBuilder.sol 100.00% <100.00%> (ø)
...ntracts/SimpleProviders/Provider/BasicProvider.sol 95.00% <100.00%> (+0.26%) ⬆️

Copy link
Member

@Lomet Lomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Big like on the pure.

contracts/Builders/SimpleBuilder.sol Outdated Show resolved Hide resolved
contracts/Builders/SimpleBuilder.sol Outdated Show resolved Hide resolved
contracts/Builders/SimpleBuilder.sol Outdated Show resolved Hide resolved
Copy link
Member

@Lomet Lomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@YouStillAlive YouStillAlive changed the title Builder preparation SimpleBuilder Sep 19, 2023
@YouStillAlive YouStillAlive marked this pull request as ready for review September 20, 2023 10:38
@Lomet Lomet enabled auto-merge (squash) September 20, 2023 10:38
@YouStillAlive YouStillAlive merged commit 167fe36 into master Sep 20, 2023
@YouStillAlive YouStillAlive deleted the issue-310 branch September 20, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add SimpleBuilder
2 participants