Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #328 (Nightly Draft) #330

Closed
wants to merge 47 commits into from
Closed

issue #328 (Nightly Draft) #330

wants to merge 47 commits into from

Conversation

Lomet
Copy link
Member

@Lomet Lomet commented Oct 2, 2023

No description provided.

@Lomet Lomet marked this pull request as draft October 2, 2023 19:45
@github-actions
Copy link

github-actions bot commented Oct 2, 2023 •
edited
Loading

Gas Test Report 📊

The gas test results are as follows:

LockDealNFT

Contract Method Min Max Avg # calls
LockDealNFT approvePoolTransfers(bool) 22087 43999 34608 7
LockDealNFT renounceOwnership() - - 23250 1
LockDealNFT safeTransferFrom(address,address,uint256,bytes) 298361 1276470 591891 33
LockDealNFT safeTransferFrom(address,address,uint256) 112732 436085 228223 32
LockDealNFT setApprovedContract(address,bool) 28108 50508 48360 80
LockDealNFT setBaseURI(string) 51171 79710 70197 3
LockDealNFT transferFrom(address,address,uint256) - - 111300 1
LockDealNFT transferOwnership(address) - - 28672 1
LockDealNFT updateAllMetadata() - - 24500 2

Simple Providers

Contract Method Min Max Avg # calls
DealProvider createNewPool(address[],uint256[]) 252202 283002 263879 65
LockDealProvider createNewPool(address[],uint256[]) 284868 300369 295608 15
TimedDealProvider createNewPool(address[],uint256[]) 342686 371424 354726 31

Advanced Providers

Contract Method Min Max Avg # calls
BundleProvider createNewPool(address[],uint256[][]) 899030 913030 912578 31
RefundProvider createNewRefundPool(address[],uint256[]) 1229928 1329501 1318445 28

Builders

Contract Method Min Max Avg # calls
SimpleBuilder buildMassPools(address[],((address,uint256)[],uint256),uint256[]) 2031640 27198910 12329665 18
SimpleRefundBuilder buildMassPools(address[],((address,uint256)[],uint256),uint256[][]) 4545136 45165974 22280589 18

Deployments

Contract Min Max Avg % of limit
BundleProvider - - 1569494 1.2 %
CollateralProvider - - 1746156 1.3 %
DealProvider - - 782997 0.6 %
DelayVaultProvider 1972789 1972813 1972801 1.5 %
LockDealNFT 3527693 3592916 3529904 2.7 %
LockDealProvider 983024 983036 983033 0.8 %
RefundProvider - - 1898858 1.5 %
SimpleBuilder - - 753862 0.6 %
TimedDealProvider 1104120 1104144 1104142 0.8 %

@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited
Loading

Codecov Report

Merging #330 (fa24c5f) into master (8d64f1a) will decrease coverage by 3.09%.
Report is 2 commits behind head on master.
The diff coverage is 85.47%.

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
- Coverage   99.84%   96.76%   -3.09%     
==========================================
  Files          23       29       +6     
  Lines         650      834     +184     
  Branches      138      181      +43     
==========================================
+ Hits          649      807     +158     
- Misses          1       27      +26
Files Coverage Δ
...dvancedProviders/BundleProvider/BundleProvider.sol 100.00% <ø> (ø)
...edProviders/DelayVaultProvider/DelayVaultState.sol 100.00% <100.00%> (ø)
...roviders/DelayVaultProvider/LastPoolOwnerState.sol 100.00% <100.00%> (ø)
...layVaultProvider/MigratorV1/DelayMigratorState.sol 100.00% <100.00%> (ø)
contracts/LockDealNFT/LockDealNFTInternal.sol 100.00% <100.00%> (ø)
contracts/LockDealNFT/LockDealNFTState.sol 100.00% <ø> (ø)
...ntracts/SimpleProviders/Provider/ProviderState.sol 100.00% <100.00%> (ø)
...dvancedProviders/DelayVaultProvider/HoldersSum.sol 97.61% <97.61%> (ø)
...roviders/DelayVaultProvider/DelayVaultProvider.sol 89.18% <89.18%> (ø)
...layVaultProvider/MigratorV1/DelayVaultMigrator.sol 51.16% <51.16%> (ø)

... and 2 files with indirect coverage changes

ashwinarora
ashwinarora reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@ashwinarora ashwinarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

contracts/AdvancedProviders/DelayVaultProvider/DelayVaultProvider.sol Outdated Show resolved Hide resolved
contracts/SimpleProviders/Provider/ProviderState.sol Show resolved Hide resolved
contracts/AdvancedProviders/DelayVaultProvider/HoldersSum.sol Outdated Show resolved Hide resolved
@YouStillAlive
requires fix (#338)
4b2c9cd 
* requires fix

* add owner check

* use currentParamsTargetLenght for requires
@YouStillAlive
avoid duplicate vaultManager address (#340)
da47a99
@YouStillAlive
use camelCase (#339)
68725e4
@Lomet Lomet mentioned this pull request Oct 4, 2023
Closed
This was linked to issues Oct 5, 2023
DeleyVaultProvider #328
Closed
DelayVaultMigrator #335
Closed
Lomet and others added 8 commits October 5, 2023 15:51
@Lomet
add ILockDealV2
86e2b0c
@YouStillAlive @Lomet
added tests (#342)
e4c396c 
* added tests

* fix DelayVaultProvider params length

* add more tests

* added more tests

* tests refactor

* reduce duplication

---------

Co-authored-by: Stan Goldin <[email protected]>
@YouStillAlive
Merge branch 'master' into Issue_#328
68c3324
@YouStillAlive
DelayProvider tests (#345)
c0604ac 
* experiments with typescript

* tests refactor

* fix amount bug

* name fix

* _subHoldersSum fix

* revert _subHoldersSum fix

* fix split bug

* tests progress

* update DelayVaultProvider

* name fix

* fix type check
@Lomet
Merge branch 'master' into Issue_#328
8aa6535
@YouStillAlive
Merge branch 'master' into Issue_#328
4ac7413
@YouStillAlive
build fixing
5e41327
@YouStillAlive
migrator preparations (#352)
fa24c5f 
* migrator preparations

* split logic

* build fixing

* add migrator revert tests

* delete unused data

* remove getLockDealNFT

* fix params length

* allow migrator to change type
@Lomet
Copy link
Member Author

Lomet commented Oct 20, 2023

moved to The-Poolz/LockDealNFT.DelayVaultProvider#1

@Lomet Lomet closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinarora ashwinarora ashwinarora left review comments

Assignees

@YouStillAlive YouStillAlive

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DelayVaultMigrator DeleyVaultProvider
3 participants
@Lomet @ashwinarora @YouStillAlive