Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refund getParams #350

Merged
merged 8 commits into from
Oct 18, 2023
Merged

refund getParams #350

merged 8 commits into from
Oct 18, 2023

Conversation

YouStillAlive
Copy link
Member

No description provided.

@YouStillAlive YouStillAlive changed the title draft refund getParams refund getParams Oct 12, 2023
@YouStillAlive YouStillAlive marked this pull request as ready for review October 13, 2023 10:23
@github-actions
Copy link

github-actions bot commented Oct 13, 2023

Gas Test Report 📊

The gas test results are as follows:

LockDealNFT

Contract Method Min Max Avg # calls
LockDealNFT approvePoolTransfers(bool) 22087 43999 33043 6
LockDealNFT renounceOwnership() - - 23250 1
LockDealNFT safeTransferFrom(address,address,uint256,bytes) 291602 1249956 625170 28
LockDealNFT safeTransferFrom(address,address,uint256) 109350 337691 180055 25
LockDealNFT setApprovedContract(address,bool) 28108 50508 47520 50
LockDealNFT setBaseURI(string) 51171 79710 70197 3
LockDealNFT transferFrom(address,address,uint256) - - 103418 1
LockDealNFT transferOwnership(address) - - 28672 1
LockDealNFT updateAllMetadata() - - 24500 2

Simple Providers

Contract Method Min Max Avg # calls
DealProvider createNewPool(address[],uint256[]) 252202 283002 263879 65
LockDealProvider createNewPool(address[],uint256[]) 284868 300369 295608 15
TimedDealProvider createNewPool(address[],uint256[]) 342686 371424 354726 31

Advanced Providers

Contract Method Min Max Avg # calls
BundleProvider createNewPool(address[],uint256[][]) 899030 913030 912578 31
RefundProvider createNewRefundPool(address[],uint256[]) 1229928 1329501 1318442 28

Builders

Contract Method Min Max Avg # calls
SimpleBuilder buildMassPools(address[],((address,uint256)[],uint256),uint256[]) 2031640 27198850 12329658 18
SimpleRefundBuilder buildMassPools(address[],((address,uint256)[],uint256),uint256[][]) 4545124 45165950 22280572 18

Deployments

Contract Min Max Avg % of limit
BundleProvider - - 1569494 1.2 %
CollateralProvider - - 1746156 1.3 %
DealProvider - - 782997 0.6 %
LockDealNFT 3486858 3552093 3489735 2.7 %
LockDealProvider 983024 983036 983035 0.8 %
RefundProvider 1898858 1898870 1898859 1.5 %
SimpleBuilder - - 753862 0.6 %
TimedDealProvider 1104132 1104144 1104142 0.8 %

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #350 (e00557e) into master (8d64f1a) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #350   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files          23       23           
  Lines         650      656    +6     
  Branches      138      138           
=======================================
+ Hits          649      655    +6     
  Misses          1        1           
Files Coverage Δ
...dvancedProviders/RefundProvider/RefundProvider.sol 100.00% <ø> (ø)
...s/AdvancedProviders/RefundProvider/RefundState.sol 100.00% <100.00%> (ø)

@Lomet Lomet enabled auto-merge (squash) October 18, 2023 09:43
@Lomet Lomet merged commit f38be7b into master Oct 18, 2023
5 checks passed
@Lomet Lomet deleted the issue-348 branch October 18, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RefundProvider getParams should return the CollateProvider and subPool params.
2 participants