Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unique sighashes with contract name prefixed #368

Merged
merged 1 commit into from
Dec 14, 2023
Merged

unique sighashes with contract name prefixed #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/AdvancedProviders/BundleProvider/BundleProvider.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ contract BundleProvider is BundleModifiers, ERC721Holder, FirewallConsumer {
///@param params[0] = lastSubPoolId
function _registerPool(uint256 poolId, uint256[] memory params)
internal
firewallProtectedSig(0xdf3aac25)
firewallProtectedSig(0x450b60bc)
validLastPoolId(poolId, params[0])
{
bundlePoolIdToLastSubPoolId[poolId] = params[0];
Expand Down
2 changes: 1 addition & 1 deletion contracts/AdvancedProviders/CollateralProvider/CollateralProvider.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ contract CollateralProvider is IFundsManager, ERC721Holder, CollateralState, Fir
/// @param params[params.length - 1] = FinishTime
function _registerPool(uint256 poolId, uint256[] calldata params)
internal
firewallProtectedSig(0xdf3aac25)
firewallProtectedSig(0x8b60dedb)
{
uint256 tokenAmount = params[0];
uint256 mainCoinAmount = params[params.length - 2];
Expand Down
2 changes: 1 addition & 1 deletion contracts/AdvancedProviders/RefundProvider/RefundProvider.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ contract RefundProvider is RefundState, IERC721Receiver, FirewallConsumer {
uint256[] memory params
)
internal
firewallProtectedSig(0xdf3aac25)
firewallProtectedSig(0xa635fdec)
validParamsLength(params.length, currentParamsTargetLength())
{
poolIdToCollateralId[poolId] = params[0];
Expand Down
2 changes: 1 addition & 1 deletion contracts/SimpleProviders/DealProvider/DealProvider.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ contract DealProvider is DealProviderState, BasicProvider {
* @param poolId The ID of the pool.
* @param params An array of additional parameters.
*/
function _registerPool(uint256 poolId, uint256[] calldata params) internal override firewallProtectedSig(0xdf3aac25) {
function _registerPool(uint256 poolId, uint256[] calldata params) internal override firewallProtectedSig(0x677df66b) {
poolIdToAmount[poolId] = params[0];
emit UpdateParams(poolId, params);
}
Expand Down
2 changes: 1 addition & 1 deletion contracts/SimpleProviders/LockProvider/LockDealProvider.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ contract LockDealProvider is BasicProvider, LockDealState {

///@param params[0] = amount
///@param params[1] = startTime
function _registerPool(uint256 poolId, uint256[] calldata params) internal override firewallProtectedSig(0xdf3aac25) {
function _registerPool(uint256 poolId, uint256[] calldata params) internal override firewallProtectedSig(0xfe3627e9) {
require(block.timestamp <= params[1], "Invalid start time");

poolIdToTime[poolId] = params[1];
Expand Down
2 changes: 1 addition & 1 deletion contracts/SimpleProviders/TimedDealProvider/TimedDealProvider.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ contract TimedDealProvider is LockDealState, DealProviderState, BasicProvider {
///@param params[0] = leftAmount = startAmount (leftAmount & startAmount must be same while creating pool)
///@param params[1] = startTime
///@param params[2] = finishTime
function _registerPool(uint256 poolId, uint256[] calldata params) internal override firewallProtectedSig(0xdf3aac25) {
function _registerPool(uint256 poolId, uint256[] calldata params) internal override firewallProtectedSig(0xb99c642c) {
require(params[2] >= params[1], "Finish time should be greater than start time");
poolIdToTime[poolId] = params[2];
poolIdToAmount[poolId] = params[0];
Expand Down
Loading