Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cloneId to RefundProvider (#370) #372

Merged
merged 2 commits into from
Dec 21, 2023
Merged

add cloneId to RefundProvider (#370) #372

merged 2 commits into from
Dec 21, 2023

Conversation

Lomet
Copy link
Member

@Lomet Lomet commented Dec 21, 2023

  • add cloneId to RefundProvider

  • move cloneVaultId to refund _register

  • fix codefactor

  • avoid duplicating split clones

YouStillAlive and others added 2 commits December 21, 2023 12:25
* add cloneId to RefundProvider

* move cloneVaultId to refund _register

* fix codefactor

* avoid duplicating split clones
Copy link

Gas Test Report 📊

The gas test results are as follows:

LockDealNFT

Contract Method Min Max Avg # calls
LockDealNFT approvePoolTransfers(bool) 22087 43999 33043 8
LockDealNFT renounceOwnership() - - 23339 1
LockDealNFT safeTransferFrom(address,address,uint256,bytes) 303756 1296212 649604 28
LockDealNFT safeTransferFrom(address,address,uint256) 117895 353244 193343 25
LockDealNFT setApprovedContract(address,bool) 28194 50594 47721 52
LockDealNFT setBaseURI(string) 51149 79688 70175 3
LockDealNFT transferFrom(address,address,uint256) 101218 119668 110443 2
LockDealNFT transferOwnership(address) - - 28694 1
LockDealNFT updateAllMetadata() - - 24533 2

Simple Providers

Contract Method Min Max Avg # calls
DealProvider createNewPool(address[],uint256[],bytes) 259161 289961 270810 68
LockDealProvider createNewPool(address[],uint256[],bytes) 294062 309580 304803 15
TimedDealProvider createNewPool(address[],uint256[],bytes) 354236 382971 366262 32

Advanced Providers

Contract Method Min Max Avg # calls
BundleProvider createNewPool(address[],uint256[][],bytes) 915184 929184 928760 33
RefundProvider createNewRefundPool(address[],uint256[],bytes,bytes) 1269687 1374342 1363526 30

Builders

Contract Method Min Max Avg # calls
SimpleBuilder buildMassPools(address[],((address,uint256)[],uint256),uint256[],bytes) 2047749 27348034 12395989 18
SimpleRefundBuilder buildMassPools(address[],((address,uint256)[],uint256),uint256[][],bytes,bytes) 4817311 47809441 23680670 18

Deployments

Contract Min Max Avg % of limit
BundleProvider - - 2476192 1.9 %
CollateralProvider 3197401 3197413 3197410 2.5 %
DealProvider - - 1494667 1.1 %
ERC20Token - - 790840 0.6 %
LockDealNFT 5122322 5187557 5125109 3.9 %
LockDealProvider 1637276 1637288 1637285 1.3 %
RefundProvider - - 3212261 2.5 %
SimpleBuilder - - 1137247 0.9 %
SimpleRefundBuilder - - 2170304 1.7 %
TimedDealProvider - - 1873839 1.4 %

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d169d0) 99.86% compared to head (54e80dc) 99.86%.
Report is 1 commits behind head on ironblocks.

Additional details and impacted files
@@             Coverage Diff             @@
##           ironblocks     #372   +/-   ##
===========================================
  Coverage       99.86%   99.86%           
===========================================
  Files              22       22           
  Lines             726      728    +2     
  Branches          179      179           
===========================================
+ Hits              725      727    +2     
  Misses              1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YouStillAlive YouStillAlive merged commit ed97edc into ironblocks Dec 21, 2023
4 checks passed
@YouStillAlive YouStillAlive deleted the temp-copy branch December 21, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants