Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sub-poolIds names #383

Merged
merged 4 commits into from
Jan 5, 2024
Merged

update sub-poolIds names #383

merged 4 commits into from
Jan 5, 2024

Conversation

YouStillAlive
Copy link
Member

No description provided.

@YouStillAlive YouStillAlive linked an issue Jan 5, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jan 5, 2024

Gas Test Report 📊

The gas test results are as follows:

LockDealNFT

Contract Method Min Max Avg # calls
LockDealNFT approvePoolTransfers(bool) 22087 43999 33043 8
LockDealNFT renounceOwnership() - - 23339 1
LockDealNFT safeTransferFrom(address,address,uint256,bytes) 303833 1296531 649766 28
LockDealNFT safeTransferFrom(address,address,uint256) 117950 353321 193417 25
LockDealNFT setApprovedContract(address,bool) 28194 50594 47721 52
LockDealNFT setBaseURI(string) 51149 79688 70175 3
LockDealNFT transferFrom(address,address,uint256) 101229 119679 110454 2
LockDealNFT transferOwnership(address) - - 28694 1
LockDealNFT updateAllMetadata() - - 24533 2

Simple Providers

Contract Method Min Max Avg # calls
DealProvider createNewPool(address[],uint256[],bytes) 259183 289983 270833 68
LockDealProvider createNewPool(address[],uint256[],bytes) 294084 309602 304825 15
TimedDealProvider createNewPool(address[],uint256[],bytes) 354258 382993 366284 32

Advanced Providers

Contract Method Min Max Avg # calls
BundleProvider createNewPool(address[],uint256[][],bytes) 915327 929327 928902 33
RefundProvider createNewRefundPool(address[],uint256[],bytes,bytes) 1269925 1374580 1363771 30

Builders

Contract Method Min Max Avg # calls
SimpleBuilder buildMassPools(address[],((address,uint256)[],uint256),uint256[],bytes) 2048068 27351359 12397750 18
SimpleRefundBuilder buildMassPools(address[],((address,uint256)[],uint256),uint256[][],bytes,bytes) 4838440 47839456 23706076 18

Deployments

Contract Min Max Avg % of limit
BundleProvider - - 2495484 1.9 %
CollateralProvider - - 3206038 2.5 %
DealProvider 1494655 1494667 1494666 1.1 %
ERC20Token - - 790840 0.6 %
LockDealProvider 1637276 1637288 1637285 1.3 %
RefundProvider - - 3233061 2.5 %
SimpleBuilder - - 1137247 0.9 %
SimpleRefundBuilder - - 2166884 1.7 %
TimedDealProvider 1873827 1873839 1873834 1.4 %

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (107b67a) 99.86% compared to head (d8285f4) 99.86%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #383   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          22       22           
  Lines         728      728           
  Branches      179      178    -1     
=======================================
  Hits          727      727           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lomet Lomet merged commit fb62e0f into master Jan 5, 2024
5 checks passed
@Lomet Lomet deleted the issue-380 branch January 5, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sub-poolIds names
2 participants