Fixed bug where thumbnail images were being generated for profiles th…

…at don't support thumbnails. (#93)
TheAcharya · Apr 23, 2024 · 561b668 · 561b668
1 parent 6c4c660
commit 561b668
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/Sources/MarkersExtractor/Export/ExportProfile Export.swift b/Sources/MarkersExtractor/Export/ExportProfile Export.swift
@@ -56,7 +56,7 @@ extension ExportProfile {
         // thumbnail images
 
         let thumbnailsProgressUnitCount: Int64 = 90
-        if let media {
+        if Self.isMediaCapable, let media {
             try await exportThumbnails(
                 markers: markers,
                 preparedMarkers: preparedMarkers,

diff --git a/Sources/MarkersExtractor/Export/Profile/MIDIFile/MIDIFileExportProfile Export.swift b/Sources/MarkersExtractor/Export/Profile/MIDIFile/MIDIFileExportProfile Export.swift
@@ -52,7 +52,7 @@ extension MIDIFileExportProfile {
         )
 
         buildMessages.forEach {
-            logger?.info("MIDI File: \($0)")
+            logger?.info("MIDI File diagnostic: \($0)")
         }
 
         let data = try midiFile.rawData()

diff --git a/Sources/MarkersExtractor/MarkersExtractor.swift b/Sources/MarkersExtractor/MarkersExtractor.swift
@@ -92,9 +92,16 @@ extension MarkersExtractor {
                 let exportMedia = try formExportMedia(projectName: projectName)
                 media = exportMedia
                 logger.info("Found project media file: \(exportMedia.videoURL.path.quoted).")
-                logger.info(
-                    "Generating \(s.imageFormat.name) thumbnail images into \(outputURL.path.quoted)."
-                )
+
+                if s.exportFormat.concreteType.isMediaCapable {
+                    logger.info(
+                        "Generating \(s.imageFormat.name) thumbnail images into \(outputURL.path.quoted)."
+                    )
+                } else {
+                    logger.info(
+                        "Export profile does not support thumbnail image generation. No thumbnails will be exported."
+                    )
+                }
             } catch {
                 // not a critical error - if no media is found, let extraction continue without media
                 media = nil