-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: leetcode zigzag solution #897
feat: leetcode zigzag solution #897
Conversation
Hey @Panquesito7 @kvedala, On my fork's Github Actions I got this error from Awesome CI Workflow Code formatter; even if I separated the two files into two different commits. 2 files are not in one and only one directory:
leetcode/src/1.c
leetcode/src/6.c
Error: Process completed with exit code 2. Any idea how I could fix it? Thanx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! 😄👍
@file does not want parameters Co-authored-by: David Leal <[email protected]>
Co-authored-by: David Leal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix clang-tidy
warnings. Let us know if you need any help here or in our Discord server. 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still failing here.
I've done |
This reverts commit b46a6af.
solved by PR #900 ? |
Still failing. 👀 |
Co-authored-by: David Leal <[email protected]>
Co-authored-by: David Leal <[email protected]>
I've seen the tests are failing in other PRs with the same issue you had in this PR. Would you like to investigate? Thanks. 🙂 |
I checked some of the waiting PR but any of them has the same issue that this one. Could you link some references? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A question: there's no main
function? 🤔
added main function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Thanks for your contribution! 😄👍
@ayaankhan98 @mishraabhinn @Panquesito7 ... ping? 😉 |
Description of Change
A solution for the ZigZag conversion problem.
References
Hacktoberfest issue
ZigZag Conversion problem on leetcode
Checklist
Notes: Solution to the 6-ZigZag conversion problem was missing. Here is (decent) one.
ZigZagConversion-SubmissionDetail-LeetCode.pdf