-
-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create palindrome.dart #187
Open
satyamnoob
wants to merge
2
commits into
TheAlgorithms:master
Choose a base branch
from
satyamnoob:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,85 @@ | ||
import 'package:test/test.dart'; | ||
|
||
void main() { | ||
palindrome(); | ||
} | ||
|
||
void palindrome() { | ||
print('Enter Words or number'); | ||
// User enter a string or a number | ||
String original = 'hannah'; | ||
|
||
// then we will reverse the input | ||
String reverseUsingLoop = reverseStringUsingLoop(original); | ||
String reverseUsingSplit = reverseStringUsingSplit(original); | ||
String reverseUsingRunes = reverseStringUsingRunes(original); | ||
String reverseUsingCodeUnits = reverseStringUsingCodeUnits(original); | ||
|
||
// then we will compare (Use any one of the four) | ||
if (original == reverseUsingLoop) { | ||
// print('Its A Palindrome'); | ||
} else { | ||
// print('Its A Not Palindrome'); | ||
} | ||
|
||
if (original == reverseUsingSplit) { | ||
// print('Its A Palindrome'); | ||
} else { | ||
// print('Its A Not Palindrome'); | ||
} | ||
|
||
if (original == reverseUsingRunes) { | ||
// print('Its A Palindrome'); | ||
} else { | ||
// print('Its A Not Palindrome'); | ||
} | ||
|
||
if (original == reverseUsingCodeUnits) { | ||
// print('Its A Palindrome'); | ||
} else { | ||
// print('Its A Not Palindrome'); | ||
} | ||
|
||
// test | ||
group('Palindrome Check', () { | ||
test('Using loop to reverse a string.', () { | ||
var string = 'hannah'; | ||
expect(string, equals(reverseStringUsingLoop(string))); | ||
}); | ||
test('Using split to reverse a string.', () { | ||
var string = 'hannah'; | ||
expect(string, equals(reverseStringUsingSplit(string))); | ||
}); | ||
test('Using runes to reverse a string.', () { | ||
var string = 'hannah'; | ||
expect(string, equals(reverseStringUsingRunes(string))); | ||
}); | ||
test('Using code units to reverse a string.', () { | ||
var string = 'hannah'; | ||
expect(string, equals(reverseStringUsingCodeUnits(string))); | ||
}); | ||
}); | ||
Comment on lines
+44
to
+61
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add negative cases |
||
} | ||
|
||
String reverseStringUsingLoop(String input) { | ||
String reversed = ""; | ||
for (int index = input.length - 1; index >= 0; index--) { | ||
reversed += input[index]; | ||
} | ||
return reversed; | ||
} | ||
|
||
String reverseStringUsingSplit(String input) { | ||
var chars = input.split(''); | ||
return chars.reversed.join(); | ||
} | ||
|
||
String reverseStringUsingRunes(String input) { | ||
var chars = input.runes.toList(); | ||
|
||
return String.fromCharCodes(chars.reversed); | ||
} | ||
|
||
String reverseStringUsingCodeUnits(String input) { | ||
return String.fromCharCodes(input.codeUnits.reversed); | ||
} | ||
Comment on lines
+64
to
+85
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All of the reversal logic are running on O(N) space. can we optimise to make it run on O(1) space. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the use of this code section?