Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create SentinelSearch.php #124

Merged
merged 15 commits into from
Jun 14, 2024
Merged

Conversation

Abhishek-Pashte
Copy link
Contributor

Added Sentinel Search algorithm in Searches algorithms

Added Sentinel Search algorithm in Searches folder
Copy link
Contributor

@darwinz darwinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing. Please add this algorithm to the Directory and add unit tests. See CONTRIBUTING if you have any questions.

Added tests for SentinelSearch.php
Added link for sentinel search
@Abhishek-Pashte
Copy link
Contributor Author

Required changes has been made

@Abhishek-Pashte
Copy link
Contributor Author

Required changes has been made. Pls review those changes

@darwinz
Copy link
Contributor

darwinz commented Oct 11, 2023

Thanks for making those changes. Please fix the linting errors that came up in the code-style workflow checks.

@darwinz
Copy link
Contributor

darwinz commented Oct 27, 2023

@Abhishek-Pashte , looks like we still have some linting errors

Copy link
Contributor

@darwinz darwinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@darwinz darwinz merged commit 8389d29 into TheAlgorithms:master Jun 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants