Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temperature conversions #169

Merged
merged 6 commits into from
Oct 19, 2024
Merged

temperature conversions #169

merged 6 commits into from
Oct 19, 2024

Conversation

MaarcooC
Copy link
Contributor

@MaarcooC MaarcooC commented Oct 3, 2024

Added 6 functions for temperature conversion between Celsius, Fahrenheit, and Kelvin with input validation.

@MaarcooC
Copy link
Contributor Author

MaarcooC commented Oct 4, 2024

added a function that checks if a number is perfect.

darwinz
darwinz requested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@darwinz darwinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting a PR! Please add proper unit tests in the appropriate tests directory and location. Also, your code needs to be linted and tests passing first, so please run PHPCS (vendor/bin/phpcs -n)

@MaarcooC
Copy link
Contributor Author

MaarcooC commented Oct 7, 2024

Sorry for that, I now added proper unit tests and ran phpcs.

MaarcooC
MaarcooC commented Oct 7, 2024
View reviewed changes
Copy link
Contributor Author

@MaarcooC MaarcooC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added unit tests and phpcs

@MaarcooC MaarcooC requested a review from darwinz October 11, 2024 15:46
darwinz
darwinz requested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@darwinz darwinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the comments to be formatted as doc comments? See here for an example.

@MaarcooC MaarcooC requested a review from darwinz October 16, 2024 13:37
darwinz
darwinz approved these changes Oct 19, 2024
View reviewed changes
Copy link
Contributor

@darwinz darwinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

@darwinz darwinz merged commit de42d6a into TheAlgorithms:master Oct 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darwinz darwinz darwinz approved these changes

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaarcooC @darwinz