Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create binary_insertion_sort.r #95

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Create binary_insertion_sort.r #95

merged 3 commits into from
Oct 5, 2023

Conversation

iMeet07
Copy link
Contributor

@iMeet07 iMeet07 commented Oct 4, 2023

Added binary-insertionSort Algorithm

@iMeet07
Create binary-insertionSort.r
fe44c76 
Added binary-insertionSort Algorithm
siriak
siriak requested changes Oct 4, 2023
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please call the file binary_insertion_sort.r

@iMeet07
Copy link
Contributor Author

iMeet07 commented Oct 4, 2023

Please call the file binary_insertion_sort.r

pls close this pull request. I have made changes in name of file and re-sent the pull request. Thank You.

@iMeet07 iMeet07 changed the title Create binary-insertionSort.r Create binary_insertion_Sort.r Oct 4, 2023
@iMeet07
Copy link
Contributor Author

iMeet07 commented Oct 4, 2023

Please call the file binary_insertion_sort.r

First I wasn’t able to edit the file but now I managed to so u can accept this contribution.

siriak
siriak requested changes Oct 5, 2023
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is S in the name capitalized? We use snake_case for file names

@iMeet07 iMeet07 changed the title Create binary_insertion_Sort.r Create binary_insertion_sort.r Oct 5, 2023
@iMeet07
Copy link
Contributor Author

iMeet07 commented Oct 5, 2023

Why is S in the name capitalized? We use snake_case for file names

so sorry. I changed it.

@siriak
Copy link
Member

siriak commented Oct 5, 2023

I mean in the file name
image

@iMeet07
Copy link
Contributor Author

iMeet07 commented Oct 5, 2023 via email

@siriak siriak mentioned this pull request Oct 5, 2023
Closed
@siriak siriak enabled auto-merge (squash) October 5, 2023 13:35
siriak
siriak approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit d73ef9d into TheAlgorithms:master Oct 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@acylam acylam Awaiting requested review from acylam acylam is a code owner

@eshom eshom Awaiting requested review from eshom eshom is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iMeet07 @siriak