Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create vincenty.rs #817

Closed

Conversation

dev-priyanshu15
Copy link

@dev-priyanshu15 dev-priyanshu15 commented Oct 12, 2024

In your mod.rs file, make sure to declare the additional modules:

code
// mod.rs
pub mod bearing;
pub mod haversine;
pub mod vincenty; // Add the new module for Vincenty formula

This setup provides a good starting point for your navigation algorithms in Rust.

Pull Request Template

Description

Please include a summary of the change and which issue (if any) is fixed.
A brief description of the algorithm and your implementation method can be helpful too. If the implemented method/algorithm is not so
well-known, it would be helpful to add a link to an article explaining it with more details.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

Please make sure that if there is a test that takes too long to run ( > 300ms), you #[ignore] that or
try to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.

In your mod.rs file, make sure to declare the additional modules:

code
// mod.rs
pub mod bearing;
pub mod haversine;
pub mod vincenty; // Add the new module for Vincenty formula
@dev-priyanshu15
Copy link
Author

add hacktoberfest label please

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.32%. Comparing base (0dbaff5) to head (0e9e30f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #817      +/-   ##
==========================================
- Coverage   95.36%   95.32%   -0.05%     
==========================================
  Files         311      311              
  Lines       22673    22673              
==========================================
- Hits        21623    21613      -10     
- Misses       1050     1060      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dev-priyanshu15
Copy link
Author

please add hacktoberfest label

@sozelfist
Copy link
Contributor

Could you please read the CONTRIBUTING guidelines before submitting the PR? By the way, don't try to spam PR just for hacktoberfest.

@vil02
Copy link
Member

vil02 commented Oct 12, 2024

The quality of this submission is so low, that the effort needed to review it is much higher than implementing this feature from the scratch.

@vil02 vil02 closed this Oct 12, 2024
@dev-priyanshu15
Copy link
Author

suggest some changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants