-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: jump directly to page when animation is not enabled. #102
base: master
Are you sure you want to change the base?
Conversation
@coderabbitai review |
Actions performedReview triggered.
|
WalkthroughIn the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant _TransformerPageViewState
participant _pageController
User->>_TransformerPageViewState: Trigger navigation event
_TransformerPageViewState->>_TransformerPageViewState: Check condition
alt Condition met
_TransformerPageViewState->>_pageController: jumpToPage(index)
end
This diagram shows the relationship among the user, Tip AI model upgrade
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- lib/src/transformer_page_view/transformer_page_view.dart (1 hunks)
Additional comments not posted (1)
lib/src/transformer_page_view/transformer_page_view.dart (1)
590-591
: LGTM! The change ensures direct page jump when animation is disabled.The added call to
_pageController.jumpToPage(index)
correctly handles the scenario where animations are disabled, ensuring the page jumps directly to the target page.
Summary by CodeRabbit