Optimize W3DPropBuffer::Draw_Props #797
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feliwir
approved these changes
Nov 16, 2022
|
I think CI needs to be retriggered or you just rebase the branch. |
xezon
force-pushed
the
optimize-w3dpropbuffer
branch
from
1ba497f to
716d4c0
Compare
feliwir
force-pushed
the
optimize-w3dpropbuffer
branch
from
716d4c0 to
3886cc0
Compare
feliwir
approved these changes
Dec 7, 2022
xezon
force-pushed
the
optimize-w3dpropbuffer
branch
from
3886cc0 to
0535668
Compare
Codecov ReportBase: 2.79% // Head: 2.79% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## develop #797 +/- ##
==========================================
- Coverage 2.79% 2.79% -0.01%
==========================================
Files 714 719 +5
Lines 64140 64223 +83
Branches 10419 10427 +8
==========================================
- Hits 1795 1792 -3
- Misses 62077 62163 +86
Partials 268 268
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Merge this earliest after Standalone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change cuts 2 obsolete conditions from W3DPropBuffer::Draw_Props. I expect compiler would do it anyway, but it is nice to shorten source code too for simplicity.