Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace deprecated call to getVarcharTypeDeclarationSQL() #158

Conversation

Chris53897
Copy link
Contributor

Needs ci run for --prefer-lowest

@johanwilfer
Copy link
Collaborator

Do you know if this is a BC break?

@Chris53897
Copy link
Contributor Author

I guess not.
That depends on the minimum version of dbal.
--prefer-lowest is Locking doctrine/dbal (3.8.0) Need to check if that is generally ok.
Deprecated in https://github.com/doctrine/dbal/releases/tag/3.4.0
But i don't know in which version the function was added.
https://github.com/doctrine/dbal/releases?q=getStringTypeDeclarationSQL&expanded=true

Internally the function is still used in dbal.
If there is a new major version 7 anyway, i suggest to just merge it for the new version. To be 100% safe.

@johanwilfer
Copy link
Collaborator

Will merge this, seems we had a mistake with orm 3 support anyway. Better to remove deprecations in the minor version then.

@johanwilfer johanwilfer merged commit 69ec5c8 into TheBigBrainsCompany:master Feb 24, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants