Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add tests for PHP 8.4 #185

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Chris53897
Copy link
Contributor

No description provided.

@johanwilfer
Copy link
Collaborator

Any idea why the tests fail?

@Chris53897
Copy link
Contributor Author

psalm and moneyphp/money (because of psalm) do not support PHP 8.4 yet.

moneyphp/money#796

@Chris53897 Chris53897 closed this Nov 22, 2024
@Chris53897 Chris53897 reopened this Nov 22, 2024
@Chris53897
Copy link
Contributor Author

moneyphp/money does now support PHP 8.4.
I need to update the PR to not install Psalm on PHP 8.4.
Move to PHPStan oder wait until it is supported by vimeo.

@Chris53897
Copy link
Contributor Author

@johanwilfer Vimeo 6 is released now with support for PHP 8.4.
But psalm is failing because of more/stronger checks.

Should this be done in this PR or in a follow up PR.
Because i do not know how much time i have to fix this psalm issues.

@johanwilfer
Copy link
Collaborator

@johanwilfer Vimeo 6 is released now with support for PHP 8.4.
But psalm is failing because of more/stronger checks.

Should this be done in this PR or in a follow up PR.
Because i do not know how much time i have to fix this psalm issues.

I don't use psalm so much myself other than in this projects where I mostly use phpstan so relying on your expertise here..

In phpstan there is a way to generate a baseline or to ignore previous error, but to not allow new ones of a similar kind to be introduced. Maybe there is some similar concepts in Psalm?

Regarding merging I rather wait with merge if it means all the psalm tests will fail going forward until fixed. We could merge it to a development branch or master maybe but at least release branches I don't want tests to fail on...

@Chris53897
Copy link
Contributor Author

I only use PHPStan as well ;)

I just created the baseline with vendor/bin/psalm --set-baseline=psalm-baseline.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants