-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add tests for PHP 8.4 #185
base: master
Are you sure you want to change the base?
Conversation
Any idea why the tests fail? |
psalm and moneyphp/money (because of psalm) do not support PHP 8.4 yet. |
moneyphp/money does now support PHP 8.4. |
@johanwilfer Vimeo 6 is released now with support for PHP 8.4. Should this be done in this PR or in a follow up PR. |
I don't use psalm so much myself other than in this projects where I mostly use phpstan so relying on your expertise here.. In phpstan there is a way to generate a baseline or to ignore previous error, but to not allow new ones of a similar kind to be introduced. Maybe there is some similar concepts in Psalm? Regarding merging I rather wait with merge if it means all the psalm tests will fail going forward until fixed. We could merge it to a development branch or master maybe but at least release branches I don't want tests to fail on... |
I only use PHPStan as well ;) I just created the baseline with |
No description provided.