Bump NUnit from 4.2.2 to 4.3.0 (#805)

* Bump NUnit from 4.2.2 to 4.3.0 Bumps [NUnit](https://github.com/nunit/nunit) from 4.2.2 to 4.3.0. - [Release notes](https://github.com/nunit/nunit/releases) - [Changelog](https://github.com/nunit/nunit/blob/main/CHANGES.md) - [Commits](nunit/nunit@4.2.2...4.3.0) --- updated-dependencies: - dependency-name: NUnit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Fix compiler error --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brandon Minnick <[email protected]>
TheCodeTraveler · Dec 16, 2024 · a40680a · a40680a
1 parent 1a240a1
commit a40680a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/Directory.Packages.props b/Directory.Packages.props
@@ -33,7 +33,7 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageVersion>
     <PackageVersion Include="NuGet.Protocol" Version="6.12.1" />
-    <PackageVersion Include="NUnit" Version="4.2.2">
+    <PackageVersion Include="NUnit" Version="4.3.0">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageVersion>

diff --git a/GitTrends.UITests/GitTrends.UITests.csproj b/GitTrends.UITests/GitTrends.UITests.csproj
@@ -26,7 +26,7 @@
   </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="Xamarin.UITest" Version="4.4.0" />
-    <PackageReference Include="NUnit" Version="4.2.2" />
+    <PackageReference Include="NUnit" Version="4.3.0" />
     <PackageReference Include="NUnit3TestAdapter" Version="4.6.0" />
   </ItemGroup>
   <ItemGroup>

diff --git a/GitTrends.UnitTests/Tests/Services/ReviewServiceTests.cs b/GitTrends.UnitTests/Tests/Services/ReviewServiceTests.cs
@@ -38,7 +38,7 @@ public async Task TryRequestReviewPromptTest_Valid()
 			Assert.That(didReviewRequestedFire_StoreReview);
 			Assert.That(storeReviewResult);
 			Assert.That(preferences.Get("MostRecentRequestDate", default(DateTime)), Is.Not.EqualTo(default(DateTime)));
-			Assert.That(preferences.Get("MostRecentReviewedBuildString", default(string)), Is.Not.EqualTo(default));
+			Assert.That(preferences.Get("MostRecentReviewedBuildString", default(string)), Is.Not.EqualTo(null));
 		});
 
 		void HandleReviewRequested_ReviewService(object? sender, EventArgs e)