-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flattend graph and added other changes of consortium meeting nov. 2024 #95
Flattend graph and added other changes of consortium meeting nov. 2024 #95
Conversation
Hey @SteffenBrinckmann, Looking into the data, there are How do others interpret/parse/handle Dataset entries that are not direct part of |
As far as I understand, all entries only have the direct children as hasParts. As such, the root data entry only has its direct children as hasParts. |
Currently our spec states:
This is also how I've handled it so far, with Dataset nodes that are not part of |
That spec. statement results necessarily in a flat graph of the top layer "./" and all other nodes being siblings on the second layer. I was not aware of this limitation and would vote to allow deep graphs. The RO-crate spec has the example of 3 layers: (https://www.researchobject.org/ro-crate/specification/1.1/data-entities.html#referencing-files-and-folders-from-the-root-data-entity but does not go into details of supplemental information) Alternative path: if we decide on keeping the current spec., then I can flatten the graph that Pasta produces but add some additional key:value-pair that contains the full hierarchy for those ELNs that handle the full graph. |
I think we never fully discussed whether we should restrict the potential directory structure in our spec. The RO-Crate spec itself seems to be pretty lax (see the URL @SteffenBrinckmann posted), but most ELNs probably won't be able to import arbitrarily nested structures, or are able to handle the possibility of having either directories or files on the "top-level", etc. Probably worth moving this into a separate issue for further discussion? |
Pause this merge until #98 is settled. |
Since everybody was going in the direction of a more flat structure: I adopted to that. Also debugged one test as it gave a false-positive. |
|
to everybodies liking? |
|
|
I just checked the RO Crate spec for something else and noticed that this section explains that |
@FlorianRhiem I would argue that if it has a description and comment, .... then it should also have a variable measured. In our context the variable measured is more loosely defined. |
created issue with ro-crate: ResearchObject/ro-crate#396 |
@FlorianRhiem according to ResearchObject/ro-crate#396 (comment), schema.org is permissive about combinations. Hence, variableMeasured is not contraditing schema.org for files. Since we use variableMeasured for datasets, I think it is most straight forward to also use it for files. I will table this topic in the next consortium meeting but merge the current Pasta.eln as it does not contradict schema.org |
For reference: https://schema.org/docs/datamodel.html it says:
|
I feel like this json-ld is a superposition of being precise and imprecise at the same time. It's strict AND lax. |
No description provided.