Merging CISLAM Experimental model (no Test Suite available) in JGrassTools

[mcfoi]

The wrapper of the main module is working correctly. All Oms sub-modules are fine. Wrappers for sub-modules might not be fully functional.

[moovida]

Hi, can I ask you to remove commented variables? If they are not needed, please just remove them.

[mcfoi]

I forgot this mail: now OmsCislam should be free from dead/commented code.

On 3 November 2014 03:50, Andrea Antonello [email protected] wrote:

In
hortonmachine/src/main/java/org/jgrasstools/hortonmachine/modules/hydrogeomorphology/cislam/OmsCislam.java:

• */

• // #############################################
• // van Genuchten parameters
• // #############################################
• @description(OMSCISLAM_inAlfaVanGen_DESCRIPTION)
• @Unit("1/m")
• @ui(JGTConstants.FILEIN_UI_HINT)
• @in
• public GridCoverage2D inAlfaVanGen = null;
• /*
• @description(OMSCISLAM_pAlfaVanGen_DESCRIPTION)
• @in
• public double pAlfaVanGen = 6.5;
• */
• @description(OMSCISLAM_inNVanGen_DESCRIPTION)

Hi, can I ask you to remove commented variables? If they are not needed,
please just remove them.

—
Reply to this email directly or view it on GitHub
https://github.com/moovida/jgrasstools/pull/8/files#r19717772.

[moovida]

@mcfoi , I gave a first quick look at everything and commented inline as you can see.

One thing that is wrong more or less everywhere, is the use of:
@ui(JGTConstants.FILEIN_UI_HINT) for in and out.

In the Oms* modules, there is no need for that, since they are not loaded in the GUI. And environments that want to generate one for GridCoverages and FeatureCollections do not need that. This UI annotation has been introduced only when using file paths, since in that case it is string and we never know if it is a path or something different. So check the inputs and outputs. Remove them from the Oms* classes and add it to the modules classes.

[mcfoi]

I fixed everything else beside the issued I commented back.
Also the problem with @ui(JGTConstants.FILEIN_UI_HINT) in Oms* modules was
fixed.

Marco

On 3 November 2014 04:16, Andrea Antonello [email protected] wrote:

@mcfoi https://github.com/mcfoi , I gave a first quick look at
everything and commented inline as you can see.

One thing that is wrong more or less everywhere, is the use of:
@ui https://github.com/UI(JGTConstants.FILEIN_UI_HINT) for in and out.

In the Oms* modules, there is no need for that, since they are not loaded
in the GUI. And environments that want to generate one for GridCoverages
and FeatureCollections do not need that. This UI annotation has been
introduced only when using file paths, since in that case it is string and
we never know if it is a path or something different. So check the inputs
and outputs. Remove them from the Oms* classes and add it to the modules
classes.

—
Reply to this email directly or view it on GitHub
#8 (comment).