-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/forms2 #86
Conversation
sourceAndOntologySelected: boolean = false; | ||
showForm: boolean = false; | ||
showLoader = false; | ||
fxLayout = 'row'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know these aren't actually getting added here, but is there no way that we can handle these with *ngIf conditions in the template file? I don't know if I've ever stored HTML styling variables in the TS class...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets discuss this on thursday.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment about flex-layout values being stored as component variables. If that's out of the scope of this PR, feel free to keep in it in the back of your head and ignore it for now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I can contribute here, I don't speak TS.
#82 #83