Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fmt dependency version mismatch in CMakeLists.txt #194

Merged
merged 2 commits into from
Dec 22, 2024

Conversation

brtmax
Copy link
Contributor

@brtmax brtmax commented Nov 14, 2024

This pull request addresses a dependency version mismatch in the CMakeLists.txt file for the fmt library. Specifically, the version of fmt specified in the CPMAddPackage section (v10.2.1) was not aligned with the version specified in the packageProject section (v9.1.0). This fix updates the packageProject dependencies to match the correct version (v10.2.1).

Copy link
Owner

@TheLartians TheLartians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for the fix!

@brtmax
Copy link
Contributor Author

brtmax commented Dec 21, 2024

@TheLartians No problem :) Is there any action you need me to do about the expected build status report? Sorry, I usually work with GitLab

@TheLartians TheLartians merged commit 5115efe into TheLartians:master Dec 22, 2024
6 checks passed
@TheLartians
Copy link
Owner

@brtmax all good, I could add another commit which apparently enabled the button for triggering the CI. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants