Skip to content

Commit

Permalink
minor Sylius#15333 [CoreBundle] Add missed deprecation block (Rafikooo)
Browse files Browse the repository at this point in the history
This PR was merged into the 1.13 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.13 <!-- see the comment below -->                  |
| Bug fix?        | no                                                      |
| New feature?    | no                                                      |
| BC breaks?      | no                                                      |
| Deprecations?   | yes <!-- don't forget to update the UPGRADE-*.md file --> |
| License         | MIT                                                          |

<!--
 - Bug fixes must be submitted against the 1.12 branch
 - Features and deprecations must be submitted against the 1.13 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
A forgotten deprecation.


Commits
-------

a2f3c94 [CoreBundle] Add missed deprecation block
279548c [Upgrade] Add a note about deprecation
  • Loading branch information
GSadee authored Sep 21, 2023
2 parents 2740020 + 279548c commit 34d6fcc
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
2 changes: 2 additions & 0 deletions UPGRADE-1.13.md
Original file line number Diff line number Diff line change
Expand Up @@ -144,3 +144,5 @@

1. The `sylius_admin_ajax_taxon_move` route has been deprecated. If you're relaying on it, consider migrating to new
`sylius_admin_ajax_taxon_move_up` and `sylius_admin_ajax_taxon_move_down` routes.

1. Not passing a `$fileLocator` to `Sylius\Bundle\CoreBundle\Fixture\Factory\ProductExampleFactory` constructor is deprecated and will be prohibited in Sylius 2.0.
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,16 @@ public function __construct(
trigger_deprecation(
'sylius/core-bundle',
'1.6',
'Not passing a $taxCategoryRepository to %s constructor is deprecated and will be removed in Sylius 2.0.',
'Not passing a $taxCategoryRepository to %s constructor is deprecated and will be prohibited in Sylius 2.0.',
self::class,
);
}

if ($this->fileLocator === null) {
trigger_deprecation(
'sylius/core-bundle',
'1.13',
'Not passing a $fileLocator to %s constructor is deprecated and will be removed in Sylius 2.0.',
self::class,
);
}
Expand Down

0 comments on commit 34d6fcc

Please sign in to comment.