[API] Add position to serialization and fix contract tests

TheMilek · Sep 23, 2024 · 848083e · 848083e
1 parent d95ff4e
commit 848083e
Show file tree

Hide file tree

Showing 11 changed files with 31 additions and 12 deletions.
diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/serialization/ProductImage.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/serialization/ProductImage.xml
@@ -59,5 +59,12 @@
             <group>sylius:admin:product:index</group>
             <group>sylius:admin:product:show</group>
         </attribute>
+
+        <attribute name="position">
+            <group>sylius:admin:product_image:index</group>
+            <group>sylius:admin:product_image:show</group>
+            <group>sylius:admin:product_image:update</group>
+            <group>sylius:admin:product:show</group>
+        </attribute>
     </class>
 </serializer>
diff --git a/tests/Api/Responses/admin/product_image/get_product_image_response.json b/tests/Api/Responses/admin/product_image/get_product_image_response.json
@@ -6,5 +6,6 @@
     "owner": "\/api\/v2\/admin\/products\/MUG",
     "type": "thumbnail",
     "path": "@[email protected]('sylius_original').endsWith('thumbnail.jpg')",
-    "productVariants": ["\/api\/v2\/admin\/product-variants\/MUG_BLUE"]
+    "productVariants": ["\/api\/v2\/admin\/product-variants\/MUG_BLUE"],
+    "position": 0
 }
diff --git a/tests/Api/Responses/admin/product_image/get_product_image_with_image_filter_response.json b/tests/Api/Responses/admin/product_image/get_product_image_with_image_filter_response.json
@@ -6,5 +6,6 @@
     "owner": "\/api\/v2\/admin\/products\/MUG",
     "type": "thumbnail",
     "path": "@[email protected]('sylius_small').endsWith('thumbnail.jpg')",
-    "productVariants": ["\/api\/v2\/admin\/product-variants\/MUG_BLUE"]
+    "productVariants": ["\/api\/v2\/admin\/product-variants\/MUG_BLUE"],
+    "position": 0
 }
diff --git a/...i/Responses/admin/product_image/get_product_images_filtered_by_variant_code_response.json b/...i/Responses/admin/product_image/get_product_images_filtered_by_variant_code_response.json
@@ -10,7 +10,8 @@
             "owner": "\/api\/v2\/admin\/products\/MUG",
             "type": "thumbnail",
             "path": "@[email protected]('sylius_original').endsWith('thumbnail.jpg')",
-            "productVariants": ["\/api\/v2\/admin\/product-variants\/MUG_BLUE"]
+            "productVariants": ["\/api\/v2\/admin\/product-variants\/MUG_BLUE"],
+            "position": 0
         }
     ],
     "hydra:totalItems": 1,

diff --git a/...duct_image/get_product_images_filtered_by_variant_code_with_an_image_filter_response.json b/...duct_image/get_product_images_filtered_by_variant_code_with_an_image_filter_response.json
@@ -10,7 +10,8 @@
             "owner": "\/api\/v2\/admin\/products\/MUG",
             "type": "thumbnail",
             "path": "@[email protected]('sylius_small').endsWith('thumbnail.jpg')",
-            "productVariants": ["\/api\/v2\/admin\/product-variants\/MUG_BLUE"]
+            "productVariants": ["\/api\/v2\/admin\/product-variants\/MUG_BLUE"],
+            "position": 0
         }
     ],
     "hydra:totalItems": 1,

diff --git a/tests/Api/Responses/admin/product_image/get_product_images_filtered_by_variant_response.json b/tests/Api/Responses/admin/product_image/get_product_images_filtered_by_variant_response.json
@@ -10,7 +10,8 @@
             "owner": "\/api\/v2\/admin\/products\/MUG",
             "type": "thumbnail",
             "path": "@[email protected]('sylius_original').endsWith('thumbnail.jpg')",
-            "productVariants": ["\/api\/v2\/admin\/product-variants\/MUG_BLUE"]
+            "productVariants": ["\/api\/v2\/admin\/product-variants\/MUG_BLUE"],
+            "position": 0
         }
     ],
     "hydra:totalItems": 1,

diff --git a/tests/Api/Responses/admin/product_image/get_product_images_for_product_response.json b/tests/Api/Responses/admin/product_image/get_product_images_for_product_response.json
@@ -10,7 +10,8 @@
             "owner": "\/api\/v2\/admin\/products\/MUG",
             "type": "thumbnail",
             "path": "@[email protected]('sylius_original').endsWith('thumbnail.jpg')",
-            "productVariants": ["\/api\/v2\/admin\/product-variants\/MUG_BLUE"]
+            "productVariants": ["\/api\/v2\/admin\/product-variants\/MUG_BLUE"],
+            "position": 0
         },
         {
             "@id": "\/api\/v2\/admin\/products\/MUG\/images\/@integer@",
@@ -19,7 +20,8 @@
             "owner": "\/api\/v2\/admin\/products\/MUG",
             "type": "main",
             "path": "@[email protected]('sylius_original').endsWith('main.jpg')",
-            "productVariants": ["\/api\/v2\/admin\/product-variants\/MUG_RED"]
+            "productVariants": ["\/api\/v2\/admin\/product-variants\/MUG_RED"],
+            "position": 1
         }
     ],
     "hydra:totalItems": 2,

diff --git a/...ses/admin/product_image/get_product_images_for_product_with_an_image_filter_response.json b/...ses/admin/product_image/get_product_images_for_product_with_an_image_filter_response.json
@@ -12,7 +12,8 @@
             "path": "@[email protected]('sylius_small').endsWith('thumbnail.jpg')",
             "productVariants": [
                 "\/api\/v2\/admin\/product-variants\/MUG_BLUE"
-            ]
+            ],
+            "position": 0
         },
         {
             "@id": "\/api\/v2\/admin\/products\/MUG\/images\/@integer@",
@@ -23,7 +24,8 @@
             "path": "@[email protected]('sylius_small').endsWith('main.jpg')",
             "productVariants": [
                 "\/api\/v2\/admin\/product-variants\/MUG_RED"
-            ]
+            ],
+            "position": 1
         }
     ],
     "hydra:totalItems": 2,

diff --git a/tests/Api/Responses/admin/product_image/post_product_image_response.json b/tests/Api/Responses/admin/product_image/post_product_image_response.json
@@ -6,5 +6,6 @@
     "owner": "\/api\/v2\/admin\/products\/MUG",
     "type": null,
     "path": "@[email protected]('sylius_original').endsWith('mugs.jpg')",
-    "productVariants": []
+    "productVariants": [],
+    "position": 3
 }
diff --git a/.../Api/Responses/admin/product_image/post_product_image_with_type_and_variant_response.json b/.../Api/Responses/admin/product_image/post_product_image_with_type_and_variant_response.json
@@ -8,5 +8,6 @@
     "path": "@[email protected]('sylius_original').endsWith('mugs.jpg')",
     "productVariants": [
         "\/api\/v2\/admin\/product-variants\/MUG_BLUE"
-    ]
+    ],
+    "position": 3
 }
diff --git a/tests/Api/Responses/admin/product_image/put_product_image_response.json b/tests/Api/Responses/admin/product_image/put_product_image_response.json
@@ -9,5 +9,6 @@
     "productVariants": [
         "\/api\/v2\/admin\/product-variants\/MUG_BLUE",
         "\/api\/v2\/admin\/product-variants\/MUG_RED"
-    ]
+    ],
+    "position": 0
 }