Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Update vitest imports #28270

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

mathdebate09
Copy link
Contributor

Because

Recently an issue (#28253) was closed for the settings globals: true not working as expected and hence manually importing vitest functions, PR for updating the same imports in the lesson Mocking Callbacks & Components

This PR

  • Import vitest functions

Issue

nil

Additional Information

nil

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: React Involves the React course label Jun 24, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. While you're at it, could you change that code block's indentation from 4 spaces to 2 spaces so it's consistent with the rest of the lesson (and course)?

Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MaoShizhong MaoShizhong merged commit 9d323c0 into TheOdinProject:main Jun 25, 2024
3 checks passed
@mathdebate09 mathdebate09 deleted the vitest_imports branch June 28, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: React Involves the React course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants