-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New lesson: Cookies #28974
base: main
Are you sure you want to change the base?
New lesson: Cookies #28974
Conversation
Remove duplicate line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Short and to the point. LGTM! |
Co-authored-by: Asartea <[email protected]>
- [What are cookies?](#introduction) | ||
- [Why might you need to set an expiry date on a cookie?](#expiresmaxage) | ||
- [Why might you want to prevent client-side JavaScript from accessing a cookie and how would you implement that?](#httponly) | ||
- [What does the "Secure" attribute do to a cookie?](#secure) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather have httpOnly attribute in the KC in place of Secure, though I'm fine without this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The httpOnly attribute is there as a KC, just with a more generally-worded question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gets the job done 👍
(Mao, I swear this is a compliment 😭 )
Because
Part of the Node Revamp milestone 2 - new lesson on Cookies.
This PR
Issue
Closes #28848
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section