Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aswain009 patch 2 #29052

Closed
wants to merge 5 commits into from
Closed

Conversation

aswain009
Copy link
Contributor

@aswain009 aswain009 commented Nov 4, 2024

Because

There are issues in the Introduction to Grid section with images and links not working properly.

This PR

Attempting to:

  • Update the image URL to display the correct image.
  • Update the link URL to take the user to the right repo for the exercise.

Issue

This does not close any issues I am aware of.

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Updated the links for the "Remember how much fun you had solving the card layout in this exercise?" image and Git repo.
added the "### Assignment" heading due to MD linting errors
@github-actions github-actions bot added the Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course label Nov 4, 2024
@CouchofTomato
Copy link
Member

Can you give some more context to the changes you want to make here?

@aswain009 aswain009 closed this Nov 7, 2024
@aswain009 aswain009 reopened this Nov 7, 2024
@aswain009
Copy link
Contributor Author

@CouchofTomato Sorry I got frustrated with the linting errors that I was getting and gave up on the change. The changes I was attempting to make are to the https://www.theodinproject.com/lessons/node-path-intermediate-html-and-css-introduction-to-grid page. The section on the page relating to "Remember how much fun you had solving the card layout in this exercise?" has an image that is not loading and a link that gives a 404. I was attempting to update the url for the image to display it properly and also provide a proper link to the exercise referenced. I kept getting linting errors in regards to the "Action Item" section missing but did not want to or need to add action items to the page. If you have any advise on how to remedy these errors let me know. Or if you want me to submit a bug ticket I can do that also.

@CouchofTomato
Copy link
Member

It looks like another PR may have resolved the issue as there is a merge conflict so closing this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants