Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign-up form: Remove password match validation message from image #29101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MaoShizhong
Copy link
Contributor

@MaoShizhong MaoShizhong commented Nov 20, 2024

Because

#28056 removed the "matching passwords" validation instruction from the sign-up form project because it requires JS and gets taught later in the JS course. The image was overlooked so not updated to reflect that removal. I've seen a couple of learners caught out by this and still trying to implement matching password validation because the image implies its necessity.

This PR

  • Removes the matching password validation error message from the design image.

Issue

N/A

Additional Information

Will open a 2nd PR with the statically link change once merged.

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course label Nov 20, 2024
@JoshDevHub JoshDevHub requested review from a team and codyloyd and removed request for a team November 20, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant