Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby on Rails: Update turbo.md #29117

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

dwlknsn
Copy link
Contributor

@dwlknsn dwlknsn commented Nov 23, 2024

Because

  1. Declaring a turbo_frame_tag without a block is used later in the lesson in the Turbo Streams section and (IMO) it was not obvious that you can call the tag without the closing <% end %> tag. After some digging into the docs, and experimentation I understood, but I though others may find this useful to be called out explicitly.
  2. It's not conventional to explicitly use id= in a rails helper tag. This declaration style was not used in the first few examples in the lesson, but then suddenly appeared in the second half. I removed them for consistency and to follow the more idiomatic rails way.

This PR

  • Fixes minor typo
  • Adds an example of the turbo_frame_tag declaration without a block.
  • Removes explicit declarations of id= in the turbo_frame_tags

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Ruby on Rails Involves the Ruby on Rails course label Nov 23, 2024
Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions 🚀

@JoshDevHub JoshDevHub merged commit c07bfa1 into TheOdinProject:main Nov 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Ruby on Rails Involves the Ruby on Rails course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants