Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
turbo_frame_tag
without a block is used later in the lesson in the Turbo Streams section and (IMO) it was not obvious that you can call the tag without the closing<% end %>
tag. After some digging into the docs, and experimentation I understood, but I though others may find this useful to be called out explicitly.id=
in a rails helper tag. This declaration style was not used in the first few examples in the lesson, but then suddenly appeared in the second half. I removed them for consistency and to follow the more idiomatic rails way.This PR
turbo_frame_tag
declaration without a block.id=
in theturbo_frame_tag
sIssue
Closes #XXXXX
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section