Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HashMap Data Structure: Update introduction paragraph #29331

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ruizterce
Copy link
Contributor

Because

Clarifies what HashMaps are and why are they useful before diving into the lesson.

This PR

  • Updates introductory paragraph of HashMap Data Structure lessons in Ruby and JavaScript paths.

Issue

Closes #29313

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added Content: JavaScript Involves the JavaScript course Content: Ruby Involves the Ruby course labels Jan 16, 2025
@ruizterce ruizterce mentioned this pull request Jan 16, 2025
3 tasks
Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small corrections just so we stay consistent with the term "hash map" (space between words throughout the lesson, but used as one word in your changes).

More my fault than yours since I spelled it with one word in the issue. But yeah, as soon as you can get that committed, I'll be good to approve and merge.

javascript/computer_science/hash_map_data_structure.md Outdated Show resolved Hide resolved
ruby/computer_science/hash_map_data_structure.md Outdated Show resolved Hide resolved
@ruizterce
Copy link
Contributor Author

ruizterce commented Jan 16, 2025

My apologies, I should've caught that! Thanks for the review, I just committed your suggested changes.

@ruizterce ruizterce requested a review from JoshDevHub January 18, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: JavaScript Involves the JavaScript course Content: Ruby Involves the Ruby course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HashMap: <needs revision>.
2 participants