Skip to content

Conversation

rainmakerV2
Copy link

@rainmakerV2 rainmakerV2 commented Oct 2, 2025

Because

The current email settings screenshot in this section (https://www.theodinproject.com/lessons/foundations-setting-up-git) is out of date. I've provided an example of the update screenshot, but I think it should be retaken/re-uploaded to the same location as the old screenshot.

Old:

GitHub Email Settings

New:

GitHub Email Settings

This PR

  • Added updated screenshot to reflect current email settings page in GitHub

Additional Information

To anyone reviewing this, please ensure the image is uploaded to the correct location - it's currently just uploaded as a GitHub attachment.

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

The current email settings screenshot in this section is out of date. I've provided an example of the update screenshot, but I think it should be retaken/re-uploaded to the same location as the old screenshot.
@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label Oct 2, 2025
@rainmakerV2 rainmakerV2 changed the title Introduction to Git lesson: Update out of date email settings image Setting up Git lesson: Update out of date email settings image Oct 3, 2025
Copy link
Contributor

@mao-sz mao-sz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Could you please follow our process for handling images in lessons: https://github.com/TheOdinProject/curriculum/blob/main/CONTRIBUTING.md#adding-images-to-the-curriculum

@rainmakerV2
Copy link
Author

Thanks for this. Could you please follow our process for handling images in lessons: https://github.com/TheOdinProject/curriculum/blob/main/CONTRIBUTING.md#adding-images-to-the-curriculum

@mao-sz - thank you for that. I was hoping I could use this PR to upload the new images to the repo but I'm noticing that now that I've done that, the merge commit link isn't accepted by https://wise-king-sullyman.github.io/better-statically-converter-react/.

Should I just close this PR and start the process from scratch following the process you linked?

@mao-sz
Copy link
Contributor

mao-sz commented Oct 6, 2025

As per the contributing guide, it's a 2 PR process. The first PR (this one) should only deal with image files. That means you need to get rid of the image link change you made. Only once this PR has been merged will you be able to get the right merge commit hash for the CDN link generator. Then you'll be able to make the second PR to update the image link(s) in the right lesson.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants