Skip to content

DOM Manipulation and Events: Update assignment to reflect changes to MDN #30211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

DOM Manipulation and Events: Update assignment to reflect changes to MDN #30211

wants to merge 2 commits into from

Conversation

rlujs
Copy link
Contributor

@rlujs rlujs commented Oct 5, 2025

Because

This PR updates the DOM manipulation assignment to use current MDN resources and also prevents students from being redirected to the top of the page due to an outdated anchor.

This PR

  • Removes the reference to "Active Learning" as these assignments are no longer labeled as such.
  • Updates the anchor of the first lesson from #active_learning_basic_dom_manipulation to #doing_some_basic_dom_manipulation since the old anchor no longer exists. This was causing students to be redirected to the top of the page instead of the assignments.
  • Individually adds the two lessons as assignments instead of redirecting only to the first lesson. This clarifies that students are expected to complete both examples.

Issue

None

Additional Information

None

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@rlujs
fix: update assignment to reflect changes to MDN
742f4d6 
- Removed reference to the outdated "Active Learning" section on MDN.
- Individually added the two lessons as assignments instead of redirecting only to the first lesson
- Updated the anchor of the first lesson

Since the old anchor no longer exists, it was redirecting students to the top of the page instead of the assignments.
@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rlujs