Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fibonacci in Red #4038

Closed
wants to merge 6 commits into from
Closed

Conversation

stefanurkal
Copy link
Contributor

@stefanurkal stefanurkal commented Nov 12, 2024

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation

I Am Adding a New Code Snippet in an Existing Language

Other Notes

In Red console I have the fibonacci printing correctly for outputs 1-10.
red does not allow anything other the a number for input so checks for "" or "a" not working either

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @stefanurkal! Thanks for contributing to this project! We are a rather small team, so it may take some time to process this request. In the meantime, there are several ways you can make yourself a part of The Renegade Coder community. For instance, you can:

Thanks for your help!

@rzuckerm rzuckerm changed the title Red fibonacci, but not passing test Add Fibonacci in Red Nov 12, 2024
Copy link
Collaborator

@rzuckerm rzuckerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sample is supposed to use command-line arguments. Please see the project description for details.

Copy link
Collaborator

@rzuckerm rzuckerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fibonacci function looks fine, but the input still need to come from command-line arguments.

Hint: See this for details on how to get command line arguments in Red. Also, please see the project description for details on what is tested.

@rzuckerm rzuckerm added enhancement Any code that improves the repo fibonacci See: https://sampleprograms.io/projects/fibonacci/ labels Nov 14, 2024
@rzuckerm
Copy link
Collaborator

rzuckerm commented Dec 2, 2024

@stefanurkal Are you planning on doing any more work on this PR? If not, please close it.

@stefanurkal stefanurkal closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo fibonacci See: https://sampleprograms.io/projects/fibonacci/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Fibonacci in Red
2 participants