Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Tests in Tex #4415

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Modify Tests in Tex #4415

merged 3 commits into from
Jan 28, 2025

Conversation

rzuckerm
Copy link
Collaborator

@rzuckerm rzuckerm commented Jan 27, 2025

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation

I Am Modifying an Existing Code Snippet or Existing Tests

  • I fixed Modify Tex Testing #4414
  • I have read about modifying existing code snippets or tests in the contributing documentation
  • I have explained why this modification is necessary either in the issue linked above or in the notes below
  • I named the pull request using Modify {PROJECT} {tests} in {LANGUAGE} format

Other Notes

I have upgraded Tex to the latest version. I have changed the existing samples to use file I/O to write to a file with the same name at the sample (e.g., hello-world.tex generates hello-world.txt) instead of creating PDF files. This has the advantage of not having to parse and convert PDF files to something more usable. Instead, all that needs to be done is to output the resulting file.

Sorry, something went wrong.

@rzuckerm rzuckerm added enhancement Any code that improves the repo tests Testing related labels Jan 27, 2025
@rzuckerm rzuckerm marked this pull request as ready for review January 27, 2025 23:21
@rzuckerm rzuckerm changed the title Modify tex Modify Tests in Tex Jan 27, 2025
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Love this approach to testing.

@rzuckerm rzuckerm merged commit 536d420 into TheRenegadeCoder:main Jan 28, 2025
4 checks passed
@rzuckerm rzuckerm deleted the modify-tex branch January 28, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo tests Testing related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify Tex Testing
2 participants