Duplicate position fix for Advanced Startup Solars (#424)

* fix: Missing reference for global->config->solarFamilies * chore: Update Changelog.md
TheStarport · Jun 14, 2024 · 908732d · 908732d
1 parent 4d491d1
commit 908732d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # Changelog
 
+## 4.0.31
+- Fixed a case in Advanced Startup Solars where randomly placed solars could occupy the same position
+
 ## 4.0.30
 - Adjusted the project file to ensure that Advanced Startup Solars is properly included in the build
 

diff --git a/plugins/advanced_startup_solars/AdvancedStartupSolars.cpp b/plugins/advanced_startup_solars/AdvancedStartupSolars.cpp
@@ -101,7 +101,7 @@ namespace Plugins::AdvancedStartupSolars
 		return solarFormation;
 	}
 
-	Position SelectSpawnLocation(SolarFamily family)
+	Position SelectSpawnLocation(SolarFamily& family)
 	{
 		auto locationIndex = RandomNumber(0, family.spawnLocations.size() - 1);
 
@@ -178,7 +178,7 @@ namespace Plugins::AdvancedStartupSolars
 			return;
 		}
 
-		for (const auto& family : global->config->solarFamilies)
+		for (auto& family : global->config->solarFamilies)
 		{
 			auto dist = RandomNumber(0, 100);