Change: Add demo charges to unused Demo Saboteur, add unique voice lines #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
commy2
commented
Aug 24, 2023
commy2
commented
- Adds previously unused voice set to the worldbuilder only Demo General Saboteur.
- Adds Suicide ability to Demo General Saboteur
- Adds placing timed and remote demo charges ability to Demo General Saboteur -- he has voice lines specifically for that
- Animation used for placing charges is from CIA Agent. It looks neat with the Saboteur model.
commy2
added
WorldBuilder
xezon
reviewed
Aug 25, 2023
|
Uh oh, Sabotage + placing demo charges is very wonky on buildings. Saboteur may collide with building and sabotage it instead of placing a bomb. Also, this allows Saboteur to target scaffolds and sabotage those. I think best is to remove infiltration from this Saboteur and make him a demolition unit entirely. |
|
Camouflaged unit + suicide ability. Very sneaky. |
xezon
reviewed
Aug 25, 2023
commy2
commented
Aug 27, 2023
commy2
commented
Aug 30, 2023
xezon
reviewed
Aug 31, 2023
xezon
approved these changes
Sep 2, 2023
| @@ -42422,6 +42422,22 @@ RU: "Саботажник: &S" | |||
| AR: "ﻱﺭﺎﺤﺘﻧﺈﻟا" | |||
| END | |||
|
|
|||
| // Patch104p @fix commy2 25/08/2023 Adds text variant for Demo Saboteur. | |||
| ZH: "非戰鬥滲透單位。 只有在他放置炸彈時會顯露出來。" | ||
| BP: "Unidade de infiltração não combatente. Visível apenas quando planta cargas de demolição." | ||
| PL: "Cywilna jednostka infiltrująca. Staje się widoczny, gdy podkłada ładunek wybuchowy." | ||
| RU: "Не боевое подразделение для проникновения. Выдает себя, когда устанавливает бомбу." |
There was a problem hiding this comment.
Closing Russian sentences end without dot.
There was a problem hiding this comment.
Because Russian text follows English style.
| @@ -4827,6 +4827,38 @@ AudioEvent SaboteurVoiceDie | |||
| End | |||
|
|
|||
|
|
|||
| ; Demo Saboteur | |||
| @@ -17398,11 +17410,17 @@ Object Demo_GLAInfantrySaboteur | |||
| End | |||
|
|
|||
| ; ***DESIGN parameters *** | |||
| DisplayName = OBJECT:Saboteur | |||
| DisplayName = OBJECT:Demo_Saboteur // Patch104p @fix commy2 25/08/2023 Adds text variant for Demo Saboteur. | |||
| @@ -2343,6 +2343,7 @@ CommandSet Demo_GLABarracksCommandSet | |||
| 3 = Demo_Command_ConstructGLAInfantryTerrorist | |||
| 4 = Demo_Command_ConstructGLAInfantryAngryMob | |||
| 6 = Demo_Command_ConstructGLAInfantryJarmenKell | |||
| 7 = Demo_Command_ConstructGLAInfantrySaboteur ; @TODO, debug remove | |||
There was a problem hiding this comment.
Needs debug removal before merge, 2x.
xezon
reviewed
Jun 10, 2024
| @@ -2703,6 +2712,7 @@ CommandSet Demo_GLABarracksCommandSetUpgrade ; unused | |||
| 3 = Demo_Command_ConstructGLAInfantryTerrorist | |||
| 4 = Demo_Command_ConstructGLAInfantryAngryMob | |||
| 6 = Demo_Command_ConstructGLAInfantryJarmenKell | |||
| 7 = Demo_Command_ConstructGLAInfantrySaboteur ; @TODO, debug remove | |||
There was a problem hiding this comment.
Do not forget to remove before commit.
xezon
reviewed
Jun 10, 2024
| Control = random | ||
| Volume = 90 | ||
| Type = ui voice player | ||
| End |
There was a problem hiding this comment.
There are also voice lines
- isadseb "Demo Saboteur" (can be used for select)
- isadsec "I sneak in and blow them up" (can be used for select or move)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.