English localization fixes and improvements #2535

xezon · 2024-11-06T16:51:32Z

English localization fixes and improvements

New edits

Patch104pZH/GameFilesEdited/Data/generals.str

new comments

All comments to US edits are done

xezon

Overall: This language edit does too many different things. There are some edits, where I have asked if other languages have been tweaked as well, which would be better suited for separate changes where all languages are edited in one go.

Why? Because it makes it much easier to review, and classify as a single change, aka it is easier to see in the commit history, easier to revert and also easier to create a matching yaml file with change descriptions for.

Here is an example of how a change that touches one specific thing:

https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2352/files

Patch104pZH/GameFilesEdited/Data/generals.str

xezon · 2024-12-09T19:24:40Z

Patch104pZH/GameFilesEdited/Data/generals.str


 CONTROLBAR:AirF_ToolTipUSABuildStealthFighter
-US: "Stealthed while moving\nEquipped with a Point Defense Laser\n\nStrong vs. base defenses\nWeak vs. rocket soldiers"
+US: "Stealthed\nEquipped with a Point Defense Laser\n\nStrong vs. base defenses\nWeak vs. rocket soldiers"


This this also tweaked for the other languages?

I will make sure of it

xezon · 2024-12-09T19:26:46Z

Patch104pZH/GameFilesEdited/Data/generals.str

 // context: Tooltip for the button that refreshes teh game and player lists
 TOOLTIP:RefreshGamePlayerList
-US: ""
+US: "Update list of games and players"


All the missing strings added here ideally are done in a separate change for all languages in one go.

Patch104pZH/GameFilesEdited/Data/generals.str

Changes v1

Comments addressed

Carpet edits

xezon

This change needs splitting. There are a multitude of string edits where all or multiple languages need to be touched. All of these need to be part of isolated changes.

Patch104pZH/GameFilesEdited/Data/generals.str

xezon · 2025-01-03T17:21:48Z

Patch104pZH/GameFilesEdited/Data/generals.str

 // context: Tooltip displayed when the user mouses over the Streak 3 battle honor icon
 TOOLTIP:BattleHonorStreak3Disabled
 US: ""
-DE: "Siegesmedaille\nFür diese Auszeichnung musst du 3 Spiele in Folge gewinnen."
+DE: ""


This probably should not remove DE texts here.

xezon · 2025-01-03T17:22:08Z

Patch104pZH/GameFilesEdited/Data/generals.str

@@ -101294,6 +101503,8 @@ AR: ""
 UK: ""
 END

+// Patch104p @fix dmgreen 06/12/2024 Changes US from "" (#2535)


There are a bunch of change comments without changes here.

xezon · 2025-01-03T17:24:12Z

Patch104pZH/GameFilesEdited/Data/generals.str

@@ -100220,9 +100418,10 @@ UK: "Реактор забезпечує на 300% більше енергії"
 END

 // Patch104p @fix xezon 26/07/2023 Removes superfluous mention of "enemy" for US, DE, FR, ES, BP, PL, RU, UK. (#2167) (#2519)
+// Patch104p @fix dmgreen 06/12/2024 Changes US from "Stealthed while moving\nEquipped with a Point Defense Laser\n\nStrong vs. base defenses\nWeak vs. rocket soldiers" (#2535)


Perhaps can simplify comment with Changes first US sentence from "Stealthed while moving"

Other than that, original text was different, because comment above does say that "enemy" was removed.

xezon · 2025-01-03T17:28:31Z

Patch104pZH/GameFilesEdited/Data/generals.str

@@ -56782,9 +56918,10 @@ UK: "Стріляє протиракетним лазером"
 END

 // Patch104p @fix xezon 20/08/2023 Improves wording for US, ES, IT, BP. (#2261)
+// Patch104p @fix dmgreen 06/12/2024 Changes US from "Heavy lift transport\nupgrades with base defense structures and Napalm Bomb\n\nStrong vs. tanks, light vehicles\nWeak vs. missile armed infantry, anti-air defenses" (#2535)


Can remove this comment and append (#2535) to comment above.

xezon · 2025-01-03T17:45:16Z

Patch104pZH/GameFilesEdited/Data/generals.str

@@ -51366,7 +51498,7 @@ END
 // Patch104p @fix xezon 20/08/2023 Fix name discrepancies with CONTROLBAR:UpgradeSuicideBomb for all latin languages. (#2250)

 HELP:Demolitions-01
-US: "HINT:\nThe Demolitions ability enables all units to detonate"
+US: "HINT:\nThe Demolitions ability enables all units to detonate after death or at your command"


The other languages are still closer to what the original English said.

xezon · 2025-01-03T17:52:02Z

Patch104pZH/GameFilesEdited/Data/generals.str

@@ -58387,10 +58528,12 @@ AR: "2030-200403-1"
 UK: "2030-200403-1"
 END

+// Patch104p @fix dmgreen 06/12/2024 Changes US from "TBD" (#2535)


This comment is wrong. Several times in this file.

xezon · 2025-01-03T17:52:49Z

Patch104pZH/GameFilesEdited/Data/generals.str

-DE: "Wo sind meine Truppen? Bitte lassen Sie mich laufen, ja? Tun Sie mir nicht weh!"
-FR: "Inconnu"
+DE: "TBD"
+FR: "TBD"


This change touches DE and FR several times unexpectedly.

xezon · 2025-01-03T17:54:54Z

Patch104pZH/GameFilesEdited/Data/generals.str

@@ -96744,9 +96932,10 @@ UK: "Відсоток виграшу для кожної армії на осн
 END

 // Patch104p @fix xezon 20/08/2023 Improves wording for US, ES, IT, BP. (#2261)
+// Patch104p @fix dmgreen 06/12/2024 Changes US from "Heavy lift transport\nupgrades with base defense structures and Nuke Bomb\n\nStrong vs. tanks, light vehicles\nWeak vs. missile armed infantry, anti-air defenses" (#2535)


Can remove this comments and append (#2535) to comment above.

xezon · 2025-01-03T17:56:02Z

Patch104pZH/GameFilesEdited/Data/generals.str


 CONTROLBAR:Infa_ToolTipChinaBuildHelix
-US: "Heavy lift assault transport\nCan upgrade with Bunker and Napalm Bomb\n\nStrong vs. tanks, light vehicles\nWeak vs. rocket soldiers, anti-air defenses"
+US: "Heavy lift assault transport\nCan upgrade with Bunker and Napalm Bombs\n\nStrong vs. tanks, light vehicles\nWeak vs. missile armed infantry, anti-air defenses"


This was meant to say "rocket soldiers" for consistency.

xezon · 2025-01-03T17:56:40Z

Patch104pZH/GameFilesEdited/Data/generals.str

@@ -97693,9 +97882,10 @@ END
 // Patch104p @fix xezon 20/08/2023 Improves wording for US, ES, IT, BP. (#2261)
 // Patch104p @fix xezon 20/08/2023 Removes incorrect upgrade information for all latin languages. (#2261)
 // Patch104p @fix xezon 20/08/2023 Removes incorrect bunker information in PL. (#2261)
+// Patch104p @fix dmgreen 06/12/2024 Changes US from "Heavy lift assault transport\nupgrades with base defense structures and Napalm Bomb\n\nStrong vs. tanks, light vehicles\nWeak vs. missile armed infantry, anti-air defenses" (#2535)


Remove this comment and append (#2535) to first comment above.

xezon · 2025-01-03T18:00:03Z

Patch104pZH/GameFilesEdited/Data/generals.str


 CONTROLBAR:ToolTipChinaBuildHelix
-US: "Heavy lift transport\nCan upgrade with base defense structures and Napalm Bomb\n\nStrong vs. tanks, light vehicles\nWeak vs. rocket soldiers, anti-air defenses"
+US: "Heavy lift transport\nCan upgrade with base defense structures and Napalm Bombs\n\nStrong vs. tanks, light vehicles\nWeak vs. rocket soldiers, anti-air defenses"


Is this also changed to plural in the other languages? DE, FR already are plural.

xezon · 2025-01-03T18:02:33Z

Patch104pZH/GameFilesEdited/Data/generals.str

 MAP:MD-USA06Warning17
-US: "WARNING:\nDr. Thrax has been known to use a Sneak Attack\nTunnel Network to surprise enemies"


I am not sure if removing "Tunnel Network" is better here. The other languages also mention tunnel networks. And technically the Sneak Attack is a Tunnel Network.

xezon · 2025-01-03T18:03:20Z

Patch104pZH/GameFilesEdited/Data/generals.str

 SCIENCE:Nuke_ChinaCarpetBomb
-US: "Nuke Bomber"
+US: "Nuke Carpet Bomber"


I do not understand the question.

Update generals.str

7f67ff9

New edits

xezon added Minor Severity: Minor < Major < Critical < Blocker Text Is text, string, localization related labels Nov 6, 2024

xezon changed the title ~~US localization fixes and improvements~~ English localization fixes and improvements Nov 6, 2024

Update generals.str

69fcd72

xezon commented Nov 22, 2024

View reviewed changes

Patch104pZH/GameFilesEdited/Data/generals.str Show resolved Hide resolved

dmgreeny added 2 commits December 4, 2024 15:08

Update generals.str

43a6604

new comments

Update generals.str

d3ae052

All comments to US edits are done

xezon commented Dec 9, 2024

View reviewed changes

dmgreeny added 4 commits December 10, 2024 16:15

Update generals.str

46b41ec

Changes v1

Update generals.str

e0d6a07

Comments addressed

Update generals.str

e636497

Carpet edits

Update generals.str

5ef03a9

xezon commented Dec 25, 2024

View reviewed changes

Update generals.str

3512ad5

xezon commented Jan 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

English localization fixes and improvements #2535

English localization fixes and improvements #2535

xezon commented Nov 6, 2024 •

edited

Loading

xezon left a comment

xezon Dec 9, 2024

dmgreeny Dec 10, 2024

xezon Dec 9, 2024

dmgreeny Dec 10, 2024

xezon left a comment

xezon Jan 3, 2025

xezon Jan 3, 2025

xezon Jan 3, 2025

xezon Jan 3, 2025

xezon Jan 3, 2025

xezon Jan 3, 2025

xezon Jan 3, 2025

xezon Jan 3, 2025

xezon Jan 3, 2025

xezon Jan 3, 2025

xezon Jan 3, 2025

xezon Jan 3, 2025

xezon Jan 3, 2025

		MAP:MD-USA06Warning17
		US: "WARNING:\nDr. Thrax has been known to use a Sneak Attack\nTunnel Network to surprise enemies"

English localization fixes and improvements #2535

Are you sure you want to change the base?

English localization fixes and improvements #2535

Conversation

xezon commented Nov 6, 2024 • edited Loading

xezon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xezon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xezon commented Nov 6, 2024 •

edited

Loading