Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error when calling compute_correspondences #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prophecy
Copy link

@prophecy prophecy commented Sep 25, 2019

This has 2 issues.

  1. Compile time error when make a build using CMAKE on my Mac (Other OS should be the same) folling this line.
    _kdTree = new nanoflann::KDTreeEigenMatrixAdaptor<VecMatType(_inSourcePoints, _leafSize);
  2. I fixed using this line
    _kdTree = new nanoflann::KDTreeEigenMatrixAdaptor<VecMatType>(_numDimensions, *_inSourcePoints);

By the way, I have removed _leafSize, which is an optional parameter, as it's kind of optimization purpose. I can make a new commit or make some tests if you prefer.

PS. I am currently considering to include MashMonk with my master thesis. I might do more tests or adjust some parameters. So, you can tell me if you need some more tests.

Thank you,

@T-AbdelAlim
Copy link

@prophecy Nice that you fixed this.
Any suggestions on how to apply this fix to Windows using the build steps described in the tutorial in Visual Studio?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants