fix(android): hide surfaceView for loading time when shutter is hidden #4060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeboub
requested changes
Aug 6, 2024
android/src/main/java/com/brentvatne/exoplayer/ExoPlayerView.java
Outdated
Show resolved
Hide resolved
bradfloodx
approved these changes
Aug 15, 2024
KrzysztofMoch
approved these changes
Aug 22, 2024
freeboub
approved these changes
Aug 22, 2024
|
I approve because code is OK, but I am not sure this is the expected behavior. |
|
When you can release this version? thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix black screen when
hideShutterViewis trueCloses #4045
Motivation
Fix #4045, #4006, #2974, #2483
Changes
shutterColorpropTest plan
run example app on android with Video
hideShutterView={true}prop - there is no black screen then