-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move to monorepo with bun #4255
base: master
Are you sure you want to change the base?
chore: move to monorepo with bun #4255
Conversation
10ef3a3
to
e64d810
Compare
@freeboub this PR will create conflicts in all PRs, so I would like to merge as many PRs as possible before this one |
Also builds are faster by |
finally a clean repo 🙏 Thank you ! |
@KrzysztofMoch I would be happy if this PR is merged soon! |
844de46
to
c36d69f
Compare
@freeboub I fine to merge it - other PRs will need to rebase but I guess this is probably inevitable |
c36d69f
to
8f629f1
Compare
@KrzysztofMoch I am not able to build samples with this PR ... on bare sample: info 💡 Tip: Make sure that you have set up your development environment correctly, by running npx react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/packages/cli-doctor/README.md#doctor FAILURE: Build failed with an exception.
SyntaxError: Unexpected token 'typeof' Node.js v22.9.0
BUILD FAILED in 466ms
I also think you should move react-native-video-plugin-sample to exemple folder as it is not made to be released. Thank you |
pod install is also failing on ios: SyntaxError: Unexpected token 'typeof' Node.js v22.9.0 Failed to apply config plugins /Users/olivier/openSource/react-native-video/examples/bare/node_modules/react-native-test-app/ios/test_app.rb:29:in [!] CocoaPods will not include resources it cannot find: The app will still build and run if they are served by the dev server. To include missing resources, make sure they exist, then run |
I have bumped react-native version in my versions
|
Summary
I have replaced yarn with bun as it is much faster.
Also changed our repo structure to mono repo so we have now:
-> docs
-> examples
| -> bare
| -> expo
-> packages
| -> react-native-video (library code)
| -> react-native-video-plugin-sample
Motivation
Speed up "node_modules" installation and allow for installing react-native-video as dependency in examples with simplify configuration.
Changes
Test plan