Fix 581 (crash on 32bit) + spelling fixes #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes 'Invalid value' error on 32 bit systems (issue 581)
|
I'm not sure how relevant the support for 32-bit is, but I agree with the fix, so ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cl_property uses a size_t to request some clGetDeviceInfo memory sizes that are actually cl_ulong (always 64 bit). On systems where size_t is 32 bit, this fails with CL_INVALID_VALUE (#581 reports this from ARM, but it can also happen on 32 bit x86).
This fix clips the values to fit in a size_t to avoid breaking ABI, but it might actually be better to switch to returning a cl_ulong.
The other commit is some spelling errors mostly found by Debian's lintian.