Fix for shutdown ordering issue #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, I verified that this addresses the shutdown crash issue. I'm no longer seeing any instances of it. |
|
Missed this PR until now, sorry. Never got the notification. I'll have to merge this on the main repo though. This is an autogenerated repo. |
|
Hi, no problem. You may want to disable pull requests for this repo in the future. |
I don't think that is possible on Github. It's possible to disable Issues though. |
Themaister
added a commit
to Themaister/parallel-rdp
that referenced
this pull request
Sep 5, 2022
|
Fixed now on master. Thanks for finding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential fix for #2
It appears that objects are currently being destructed in the incorrect order. The Renderer is shutdown first while the CommandRing is still using it.
I don't have a test case to reliably reproduce this, I'm only going from crash reporting, so I can't say with 100% certainty that this will fix it until I deploy it.