Support for ST7567 LCD I2C display driver #310
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my app I noticed that each time I called setTargetFPS the transitions
would become faster and faster, until finally they don't even take one
frame. The problem was that the FP math for calculating changeRatio
would (because of rounding err) keep shrinking the number of ticksPerFrame.
This change instead computs ticksPerFrame/perTransition based on the
requested display time, so error can't accumulate from a series of calls.
(In my app I only bump up target FPS before each transition but then
I lower it down again afterwards to save CPU)
(Also makes it easier to share code when users of library are targeting multiple platforms)
- allow -1 as value for _sda and _scl parameters (see: 6a56151 ) - use same autoinit logic
Treat SH1106 controller the same as SSD1306
Bugfix and Improve the details in OLEDDisplayUiState during transition
add frame notification bounceyness
…sd1306 into ThingPulse-master
Fix remaining CI problems on native build
|
@marcelstoer Hey, any chance we could get these fixes merged, we're currently trying to minimize the amount of out-of-sync forks we have, thanks. |
|
We ignore PRs labelled as 'Draft' by the authors. We'll take a look once the author considers it done. |
If memory serves, this change has an issue with one of Meshtastic build targets. That's why it's still in draft. |
Include a different header to select the OLED Controller based on a parameter that is probed early on the I2C bus in the Meshtastic Firmware
Enable selection of I2C wire interface on Pico RP2040 platform.
upstream changes
Move SetGeometry to public space
Always break on newline character
Restore log buffer: revert upstream changes
fixed name collision for keyword NONE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP driver for the ST7567 LCD chip. Do not merge. I'm just opening this as a draft to remind me and come back and make a clean PR later.
Thanks for the lib. I used it on previous versions of our meshtastic project, and just now added a device that has an LCD screen.