try add astar in classic_solvers.py; add some functions in utils.py to support NetworkX and GraphML formats #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #63 +/- ##
==========================================
- Coverage 93.67% 93.04% -0.64%
==========================================
Files 19 20 +1
Lines 6993 7578 +585
==========================================
+ Hits 6551 7051 +500
- Misses 442 527 +85
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rogerwwww
reviewed
Jul 17, 2023
rogerwwww
reviewed
Jul 17, 2023
docs/auto_examples/index.rst
Outdated
There was a problem hiding this comment.
Plz revert commits on this file.
rogerwwww
reviewed
Jul 17, 2023
There was a problem hiding this comment.
Plz revert commits on this file.
rogerwwww
reviewed
Jul 17, 2023
There was a problem hiding this comment.
Plz revert commits on this file.
rogerwwww
reviewed
Jul 17, 2023
pygmtools/classic_solvers.py
Outdated
| return_network=False, pretrain='AIDS700nef',backend=None,**kwargs): | ||
|
|
||
| r""" | ||
| GENN-A* solver for graph matching based on Graph Neural Network. |
There was a problem hiding this comment.
Add more descriptions for GENN, A-star algorithm, graph edit distance problem, citation information, etc.
rogerwwww
reviewed
Jul 17, 2023
rogerwwww
reviewed
Jul 18, 2023
tests/test_a_star/a_star.pyx
Outdated
Comment on lines
28
to
46
| #cdef class TreeNode: | ||
| # cdef public x_indices | ||
| # cdef public double gplsh | ||
| # cdef public long idx | ||
| # | ||
| # def __init__(self, x_indices, double gplsh, long idx): | ||
| # self.x_indices = x_indices | ||
| # self.gplsh = gplsh | ||
| # self.idx = idx | ||
|
|
||
| #cdef (double, long) key_func(TreeNode ele): | ||
| #cdef tuple key_func(TreeNode ele): | ||
| # cdef double gplsh = ele.gplsh | ||
| # cdef long idx = ele.idx | ||
| # return gplsh, -idx | ||
|
|
||
| #cdef bool comp_func(TreeNode a, TreeNode b): | ||
| # # note - no protection if allocated memory isn't long enough | ||
| # return a.gplsh < a.gplsh |
…to be modified back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.