Fix some unit tests and bugs

ThomasMeissnerDS · Oct 14, 2023 · a2d97f4 · a2d97f4
1 parent dae68b9
commit a2d97f4
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/bluecast/ml_modelling/xgboost.py b/bluecast/ml_modelling/xgboost.py
@@ -168,7 +168,7 @@ def autotune(
         if (
             not self.conf_params_xgboost
             or not self.conf_training
-            or self.experiment_tracker
+            or not self.experiment_tracker
         ):
             raise ValueError(
                 "conf_params_xgboost, conf_training or experiment_tracker is None"

diff --git a/bluecast/tests/test_cast_cv.py b/bluecast/tests/test_cast_cv.py
@@ -23,7 +23,6 @@ def test_blueprint_cv_xgboost(synthetic_train_test_data):
     df_val = synthetic_train_test_data[1]
     xgboost_param_config = XgboostTuneParamsConfig()
     xgboost_param_config.steps_max = 100
-    xgboost_param_config.num_leaves_max = 16
     train_config = TrainingConfig()
     train_config.hyperparameter_tuning_rounds = 10
 

diff --git a/bluecast/tests/test_shap_explanations.py b/bluecast/tests/test_shap_explanations.py
@@ -27,7 +27,6 @@ def test_shap_explanations():
     df_val = create_synthetic_dataframe(100, random_state=21)
     xgboost_param_config = XgboostTuneParamsConfig()
     xgboost_param_config.steps_max = 100
-    xgboost_param_config.num_leaves_max = 16
     train_config = TrainingConfig()
     train_config.hyperparameter_tuning_rounds = 10
     train_config.enable_feature_selection = False